* [PATCH] [media] tc90522: declare tc90522_functionality as static
@ 2014-09-23 20:02 Mauro Carvalho Chehab
2014-09-24 4:13 ` Akihiro TSUKADA
0 siblings, 1 reply; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2014-09-23 20:02 UTC (permalink / raw)
To: Linux Media Mailing List
Cc: Mauro Carvalho Chehab, Mauro Carvalho Chehab, Akihiro Tsukada
drivers/media/dvb-frontends/tc90522.c:706:5: warning: symbol 'tc90522_functionality' was not declared. Should it be static?
drivers/media/dvb-frontends/tc90522.c:706:5: warning: no previous prototype for 'tc90522_functionality' [-Wmissing-prototypes]
u32 tc90522_functionality(struct i2c_adapter *adap)
^
Cc: Akihiro Tsukada <tskd08@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
diff --git a/drivers/media/dvb-frontends/tc90522.c b/drivers/media/dvb-frontends/tc90522.c
index f4760dd998c3..cdd9808c322c 100644
--- a/drivers/media/dvb-frontends/tc90522.c
+++ b/drivers/media/dvb-frontends/tc90522.c
@@ -703,7 +703,7 @@ tc90522_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
return (ret == j) ? num : ret;
}
-u32 tc90522_functionality(struct i2c_adapter *adap)
+static u32 tc90522_functionality(struct i2c_adapter *adap)
{
return I2C_FUNC_I2C;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] tc90522: declare tc90522_functionality as static
2014-09-23 20:02 [PATCH] [media] tc90522: declare tc90522_functionality as static Mauro Carvalho Chehab
@ 2014-09-24 4:13 ` Akihiro TSUKADA
0 siblings, 0 replies; 2+ messages in thread
From: Akihiro TSUKADA @ 2014-09-24 4:13 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Linux Media Mailing List
Sorry to bother you with those build warnings.
Somehow I didn't see them when I built the modules myself on 64bit box.
maybe since I forgot to test all-y config (and 32bit build),
the gcc cmd did not include [-Wmissing-prototypes].
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-24 4:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-23 20:02 [PATCH] [media] tc90522: declare tc90522_functionality as static Mauro Carvalho Chehab
2014-09-24 4:13 ` Akihiro TSUKADA
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).