From: Shuah Khan <shuahkh@osg.samsung.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Shuah Khan <shuah.kh@samsung.com>
Cc: Fabian Frederick <fabf@skynet.be>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [patch] [media] xc5000: use after free in release()
Date: Thu, 25 Sep 2014 08:00:34 -0600 [thread overview]
Message-ID: <54242002.8020408@osg.samsung.com> (raw)
In-Reply-To: <20140925114008.GC3708@mwanda>
On 09/25/2014 05:40 AM, Dan Carpenter wrote:
> I moved the call to hybrid_tuner_release_state(priv) after
> "priv->firmware" dereference.
>
> Fixes: 5264a522a597 ('[media] media: tuner xc5000 - release firmwware from xc5000_release()')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/media/tuners/xc5000.c b/drivers/media/tuners/xc5000.c
> index e44c8ab..803a0e6 100644
> --- a/drivers/media/tuners/xc5000.c
> +++ b/drivers/media/tuners/xc5000.c
> @@ -1333,9 +1333,9 @@ static int xc5000_release(struct dvb_frontend *fe)
>
> if (priv) {
> cancel_delayed_work(&priv->timer_sleep);
> - hybrid_tuner_release_state(priv);
> if (priv->firmware)
> release_firmware(priv->firmware);
> + hybrid_tuner_release_state(priv);
> }
>
> mutex_unlock(&xc5000_list_mutex);
>
Thanks for catching it.
Reviewed-by: Shuah Khan <shuahkh@osg.samsung.com>
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2014-09-25 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 11:40 [patch] [media] xc5000: use after free in release() Dan Carpenter
2014-09-25 14:00 ` Shuah Khan [this message]
2014-10-15 13:40 ` Dan Carpenter
2014-10-15 15:12 ` Shuah Khan
2014-10-15 16:15 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54242002.8020408@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=dan.carpenter@oracle.com \
--cc=fabf@skynet.be \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=shuah.kh@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).