From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:49278 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013AbaIYPEv (ORCPT ); Thu, 25 Sep 2014 11:04:51 -0400 Message-ID: <54242F0F.9020702@iki.fi> Date: Thu, 25 Sep 2014 18:04:47 +0300 From: Antti Palosaari MIME-Version: 1.0 To: Matthias Schwarzott , linux-media@vger.kernel.org, mchehab@osg.samsung.com Subject: Re: [PATCH 04/12] cx231xx: give each master i2c bus a seperate name References: <1411621684-8295-1-git-send-email-zzam@gentoo.org> <1411621684-8295-4-git-send-email-zzam@gentoo.org> In-Reply-To: <1411621684-8295-4-git-send-email-zzam@gentoo.org> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: So this patch adds bus number to adapter name as postfix? "cx231xx" => "cx231xx-1" I have no clear opinion for that. I think name should be given when adapter is crated, not afterwards. regards Antti On 09/25/2014 08:07 AM, Matthias Schwarzott wrote: > Signed-off-by: Matthias Schwarzott > --- > drivers/media/usb/cx231xx/cx231xx-i2c.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx-i2c.c > index a30d400..178fa48 100644 > --- a/drivers/media/usb/cx231xx/cx231xx-i2c.c > +++ b/drivers/media/usb/cx231xx/cx231xx-i2c.c > @@ -506,6 +506,7 @@ void cx231xx_do_i2c_scan(struct cx231xx *dev, int i2c_port) > int cx231xx_i2c_register(struct cx231xx_i2c *bus) > { > struct cx231xx *dev = bus->dev; > + char bus_name[3]; > > BUG_ON(!dev->cx231xx_send_usb_command); > > @@ -513,6 +514,10 @@ int cx231xx_i2c_register(struct cx231xx_i2c *bus) > bus->i2c_adap.dev.parent = &dev->udev->dev; > > strlcpy(bus->i2c_adap.name, bus->dev->name, sizeof(bus->i2c_adap.name)); > + bus_name[0] = '-'; > + bus_name[1] = '0' + bus->nr; > + bus_name[2] = '\0'; > + strlcat(bus->i2c_adap.name, bus_name, sizeof(bus->i2c_adap.name)); > > bus->i2c_adap.algo_data = bus; > i2c_set_adapdata(&bus->i2c_adap, &dev->v4l2_dev); > -- http://palosaari.fi/