From: Hans de Goede <hdegoede@redhat.com>
To: Nicolas Dufresne <nicolas.dufresne@collabora.com>,
linux-media@vger.kernel.org
Subject: Re: Regression: in v4l2 converter does not set the buffer.length anymore
Date: Tue, 30 Sep 2014 16:04:44 +0200 [thread overview]
Message-ID: <542AB87C.1070306@redhat.com> (raw)
In-Reply-To: <5429CDD6.9050809@collabora.com>
Hi,
On 09/29/2014 11:23 PM, Nicolas Dufresne wrote:
> This was initially reported to GStreamer project:
> https://bugzilla.gnome.org/show_bug.cgi?id=737521
>
> We track this down to be a regression introduced in v4l2-utils from version 1.4.0. In recent GStreamer we make sure the buffer.length field (retreived with QUERYBUF) is bigger or equal to the expected sizeimage (as obtained in S_FMT). This is to fail cleanly and avoid buffer overflow if a driver (or libv4l2) endup doing a short allocation. Since 1.4.0, this field is always 0 if an emulated format is selected.
>
> Reverting patch 10213c brings back normal behaviour:
> http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=10213c975afdfcc90aa7de39e66c40cd7e8a57f7
>
> This currently makes use of any emulated format impossible in GStreamer. v4l2-utils 1.4.0 is being shipped at least in debian/unstable at the moment.
Oops, thanks for the bug report.
I've created a 3 patch patch-set fixing this, which I'll send right after
this mail. The actual fix is in the 2nd patch, the first patch and third
patches fix 2 unrelated bugs which I noticed while working on this.
Regards,
Hans
prev parent reply other threads:[~2014-09-30 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 21:23 Regression: in v4l2 converter does not set the buffer.length anymore Nicolas Dufresne
2014-09-30 14:04 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542AB87C.1070306@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=nicolas.dufresne@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).