From: Antti Palosaari <crope@iki.fi>
To: Olli Salonen <olli.salonen@iki.fi>, linux-media@vger.kernel.org
Subject: Re: [PATCH] cx23885: initialize config structs for T9580
Date: Wed, 01 Oct 2014 22:51:37 +0300 [thread overview]
Message-ID: <542C5B49.80605@iki.fi> (raw)
In-Reply-To: <1411528014-14650-1-git-send-email-olli.salonen@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>
That should go Kernel 3.18.
Antti
On 09/24/2014 06:06 AM, Olli Salonen wrote:
> The config structs used for DVBSky T9580 were not initialized. This patch fixes that.
>
> Signed-off-by: Olli Salonen <olli.salonen@iki.fi>
> ---
> drivers/media/pci/cx23885/cx23885-dvb.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/pci/cx23885/cx23885-dvb.c b/drivers/media/pci/cx23885/cx23885-dvb.c
> index 13734b8..4cb9031 100644
> --- a/drivers/media/pci/cx23885/cx23885-dvb.c
> +++ b/drivers/media/pci/cx23885/cx23885-dvb.c
> @@ -1600,6 +1600,7 @@ static int dvb_register(struct cx23885_tsport *port)
> break;
>
> /* attach tuner */
> + memset(&m88ts2022_config, 0, sizeof(m88ts2022_config));
> m88ts2022_config.fe = fe0->dvb.frontend;
> m88ts2022_config.clock = 27000000;
> memset(&info, 0, sizeof(struct i2c_board_info));
> @@ -1635,6 +1636,7 @@ static int dvb_register(struct cx23885_tsport *port)
> /* port c - terrestrial/cable */
> case 2:
> /* attach frontend */
> + memset(&si2168_config, 0, sizeof(si2168_config));
> si2168_config.i2c_adapter = &adapter;
> si2168_config.fe = &fe0->dvb.frontend;
> si2168_config.ts_mode = SI2168_TS_SERIAL;
> @@ -1654,6 +1656,7 @@ static int dvb_register(struct cx23885_tsport *port)
> port->i2c_client_demod = client_demod;
>
> /* attach tuner */
> + memset(&si2157_config, 0, sizeof(si2157_config));
> si2157_config.fe = fe0->dvb.frontend;
> memset(&info, 0, sizeof(struct i2c_board_info));
> strlcpy(info.type, "si2157", I2C_NAME_SIZE);
>
--
http://palosaari.fi/
prev parent reply other threads:[~2014-10-01 19:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 3:06 [PATCH] cx23885: initialize config structs for T9580 Olli Salonen
2014-10-01 19:51 ` Antti Palosaari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542C5B49.80605@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=olli.salonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).