From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: linux-media@vger.kernel.org, pebolle@tiscali.nl,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] [media] Remove references to non-existent PLAT_S5P symbol
Date: Mon, 06 Oct 2014 18:06:49 +0200 [thread overview]
Message-ID: <5432BE19.90508@samsung.com> (raw)
In-Reply-To: <5432BAA7.4010008@gmail.com>
On 06/10/14 17:52, Tomasz Figa wrote:
> On 06.10.2014 17:39, Sylwester Nawrocki wrote:
>> diff --git a/drivers/media/platform/exynos4-is/Kconfig b/drivers/media/platform/exynos4-is/Kconfig
>> index 77c9512..b3b270a 100644
>> --- a/drivers/media/platform/exynos4-is/Kconfig
>> +++ b/drivers/media/platform/exynos4-is/Kconfig
>> @@ -2,7 +2,7 @@
>> config VIDEO_SAMSUNG_EXYNOS4_IS
>> bool "Samsung S5P/EXYNOS4 SoC series Camera Subsystem driver"
>> depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
>> - depends on (PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST)
>> + depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
>> depends on OF && COMMON_CLK
>> help
>> Say Y here to enable camera host interface devices for
>> @@ -57,7 +57,7 @@ endif
>>
>> config VIDEO_EXYNOS4_FIMC_IS
>> tristate "EXYNOS4x12 FIMC-IS (Imaging Subsystem) driver"
>> - depends on HAS_DMA
>> + depends on HAS_DMA && !ARCH_S5PV210
>
> Hmm, does this change really do the intended thing?
>
> Since both S5PV210 and Exynos are multiplatform-aware, now whenever
> ARCH_S5PV210 is enabled, it isn't possible to enable
> VIDEO_EXYNOS4_FIMC_IS, even though ARCH_EXYNOS can be enabled as well at
> the same time.
Sorry, I missed S5PV210 supports ARCH_MULTIPLATFORM, let me resend
with that line removed. Thanks for pointing out.
--
Regards,
Sylwester
prev parent reply other threads:[~2014-10-06 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 15:39 [PATCH] [media] Remove references to non-existent PLAT_S5P symbol Sylwester Nawrocki
2014-10-06 15:52 ` Tomasz Figa
2014-10-06 16:06 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5432BE19.90508@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).