From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:51656 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753203AbaJFQGw (ORCPT ); Mon, 6 Oct 2014 12:06:52 -0400 Message-id: <5432BE19.90508@samsung.com> Date: Mon, 06 Oct 2014 18:06:49 +0200 From: Sylwester Nawrocki MIME-version: 1.0 To: Tomasz Figa Cc: linux-media@vger.kernel.org, pebolle@tiscali.nl, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] [media] Remove references to non-existent PLAT_S5P symbol References: <1412609947-8358-1-git-send-email-s.nawrocki@samsung.com> <5432BAA7.4010008@gmail.com> In-reply-to: <5432BAA7.4010008@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 06/10/14 17:52, Tomasz Figa wrote: > On 06.10.2014 17:39, Sylwester Nawrocki wrote: >> diff --git a/drivers/media/platform/exynos4-is/Kconfig b/drivers/media/platform/exynos4-is/Kconfig >> index 77c9512..b3b270a 100644 >> --- a/drivers/media/platform/exynos4-is/Kconfig >> +++ b/drivers/media/platform/exynos4-is/Kconfig >> @@ -2,7 +2,7 @@ >> config VIDEO_SAMSUNG_EXYNOS4_IS >> bool "Samsung S5P/EXYNOS4 SoC series Camera Subsystem driver" >> depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API >> - depends on (PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST) >> + depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST >> depends on OF && COMMON_CLK >> help >> Say Y here to enable camera host interface devices for >> @@ -57,7 +57,7 @@ endif >> >> config VIDEO_EXYNOS4_FIMC_IS >> tristate "EXYNOS4x12 FIMC-IS (Imaging Subsystem) driver" >> - depends on HAS_DMA >> + depends on HAS_DMA && !ARCH_S5PV210 > > Hmm, does this change really do the intended thing? > > Since both S5PV210 and Exynos are multiplatform-aware, now whenever > ARCH_S5PV210 is enabled, it isn't possible to enable > VIDEO_EXYNOS4_FIMC_IS, even though ARCH_EXYNOS can be enabled as well at > the same time. Sorry, I missed S5PV210 supports ARCH_MULTIPLATFORM, let me resend with that line removed. Thanks for pointing out. -- Regards, Sylwester