From: Ulrich Eckhardt <uli-lirc@uli-eckhardt.de>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: linux-media@vger.kernel.org
Subject: Re: Tevii S480 on Unicable SCR System
Date: Wed, 08 Oct 2014 20:28:10 +0200 [thread overview]
Message-ID: <5435823A.8000309@uli-eckhardt.de> (raw)
In-Reply-To: <20141008150038.4ca96c22.m.chehab@samsung.com>
Am 08.10.2014 um 20:00 schrieb Mauro Carvalho Chehab:
> Em Wed, 08 Oct 2014 18:52:09 +0200
> Ulrich Eckhardt <uli-lirc@uli-eckhardt.de> escreveu:
>>
>> /*
>> + * Ensure that frontend voltage is switched off on initialization
>> + */
>> + if (dvb_powerdown_on_sleep) {
>
> I'm wandering why to test if (dvb_powerdown_on_sleep) here...
>
> MODULE_PARM_DESC(dvb_powerdown_on_sleep, "0: do not power down, 1: turn LNB voltage off on sleep (default)");
>
> That controls what happens when the frontend's thread stops, and not
> what happens during device initialization.
> So, IMHO, it doesn't apply here.
OK, I agree.
> My vote is to fix it at the driver's level.
So if no other opinions turns up the next days and this problem occurs only on
the Tevii card, I will reformat my patch in my first E-Mail correctly for
submission.
Best Regards
Uli
--
Ulrich Eckhardt http://www.uli-eckhardt.de
Ein Blitzableiter auf dem Kirchturm ist das denkbar stärkste
Misstrauensvotum gegen den lieben Gott. (Karl Krauss)
next prev parent reply other threads:[~2014-10-08 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 18:42 Tevii S480 on Unicable SCR System Ulrich Eckhardt
2014-10-08 16:52 ` Ulrich Eckhardt
2014-10-08 18:00 ` Mauro Carvalho Chehab
2014-10-08 18:28 ` Ulrich Eckhardt [this message]
2014-10-10 17:19 ` [PATCH][media] Fix LNB supply voltage of Tevii S480 on initialization Ulrich Eckhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5435823A.8000309@uli-eckhardt.de \
--to=uli-lirc@uli-eckhardt.de \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).