From: Antti Palosaari <crope@iki.fi>
To: Olli Salonen <olli.salonen@iki.fi>, linux-media@vger.kernel.org
Cc: nibble.max@gmail.com
Subject: Re: [PATCH 4/4] dvbsky: add option to disable IR receiver
Date: Sun, 12 Oct 2014 13:12:26 +0300 [thread overview]
Message-ID: <543A540A.2010507@iki.fi> (raw)
In-Reply-To: <1413108191-32510-4-git-send-email-olli.salonen@iki.fi>
On 10/12/2014 01:03 PM, Olli Salonen wrote:
> Added an option disable_rc that can be used to disable the IR receiver polling for this module.
>
> Signed-off-by: Olli Salonen <olli.salonen@iki.fi>
> ---
> drivers/media/usb/dvb-usb-v2/dvbsky.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c
> index 5c7387a..71a3324 100644
> --- a/drivers/media/usb/dvb-usb-v2/dvbsky.c
> +++ b/drivers/media/usb/dvb-usb-v2/dvbsky.c
> @@ -25,6 +25,10 @@
> #define DVBSKY_MSG_DELAY 0/*2000*/
> #define DVBSKY_BUF_LEN 64
>
> +static int dvb_usb_dvbsky_disable_rc;
> +module_param_named(disable_rc, dvb_usb_dvbsky_disable_rc, int, 0644);
> +MODULE_PARM_DESC(disable_rc, "Disable inbuilt IR receiver.");
> +
> DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);
>
> struct dvbsky_state {
> @@ -218,6 +222,10 @@ static int dvbsky_rc_query(struct dvb_usb_device *d)
>
> static int dvbsky_get_rc_config(struct dvb_usb_device *d, struct dvb_usb_rc *rc)
> {
> + if (dvb_usb_dvbsky_disable_rc)
> + return 0;
> +
> + rc->map_name = RC_MAP_DVBSKY;
> rc->allowed_protos = RC_BIT_RC5;
> rc->query = dvbsky_rc_query;
> rc->interval = 300;
> @@ -450,7 +458,7 @@ static struct dvb_usb_device_properties dvbsky_s960_props = {
>
> static const struct usb_device_id dvbsky_id_table[] = {
> { DVB_USB_DEVICE(0x0572, 0x6831,
> - &dvbsky_s960_props, "DVBSky S960/S860", RC_MAP_DVBSKY) },
> + &dvbsky_s960_props, "DVBSky S960/S860", NULL) },
Why you removed default keytable too?
> { }
> };
> MODULE_DEVICE_TABLE(usb, dvbsky_id_table);
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-10-12 10:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 10:03 [PATCH 1/4] dvbsky: don't print MAC address from read_mac_address Olli Salonen
2014-10-12 10:03 ` [PATCH 2/4] dvbsky: added debug logging Olli Salonen
2014-11-03 13:04 ` Mauro Carvalho Chehab
2014-11-03 13:39 ` Antti Palosaari
2014-10-12 10:03 ` [PATCH 3/4] dvbsky: clean logging Olli Salonen
2014-10-12 10:03 ` [PATCH 4/4] dvbsky: add option to disable IR receiver Olli Salonen
2014-10-12 10:12 ` Antti Palosaari [this message]
2014-10-12 10:52 ` Olli Salonen
2014-10-12 11:31 ` [PATCHv2 " Olli Salonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543A540A.2010507@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=nibble.max@gmail.com \
--cc=olli.salonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).