[PATCH] Turn bothersome error into a debug message

[Johann Klammer <klammerj@a1.net>]

Once again...

On 09/30/2014 07:21 PM, Johann Klammer wrote:
> Hello,
> 
> After updating the kernel to 3.14.15 I am seeing these messages:
> 
> [273684.964081] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
> timed out while waiting for registers getting programmed
> [273690.020061] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
> timed out while waiting for registers getting programmed
> [273695.076082] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
> timed out while waiting for registers getting programmed
> [273700.132077] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
> timed out while waiting for registers getting programmed
> [273705.188070] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
> timed out while waiting for registers getting programmed
> [273710.244066] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
> timed out while waiting for registers getting programmed
> [273715.300187] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
> timed out while waiting for registers getting programmed
> [273720.356068] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
> timed out while waiting for registers getting programmed
> [273725.412188] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
> timed out while waiting for registers getting programmed
> [273730.468094] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
> timed out while waiting for registers getting programmed
> [273735.524070] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
> timed out while waiting for registers getting programmed
> [273740.580176] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
> timed out while waiting for registers getting programmed
> 
> filling up the logs(one about every 5 seconds).
> 
> The TV card is a Terratec Cinergy 1200 DVBS (I believe.. it's rather old).
> 
> I can not observe any erratic behavior, just those pesky messages...
> 
> I see there was an earlier post here in 2008 about a similar
> problem...(Cinergy 1200 DVB-C... a coincidence?)
> 
> What does it mean?
> Do I need to be worried?
> 
> I am using a debian testing on a 32 bit box.
> The previous kernel was linux-image-3.12-1-486.
> It did not show those messages, but maybe due to some configure
> options... I built this one from linux-source-3.14...
> 
Answering my own question:
Other posts suggests that it is not actually an error on cards without a
CI interface. Here's a patch that turns it into a debug message, so it
does not clobber the logs.

--- linux-source-3.14/drivers/media/common/saa7146/saa7146_core.c.orig
2014-07-31 23:51:43.000000000 +0200
+++ linux-source-3.14/drivers/media/common/saa7146/saa7146_core.c
2014-10-06 18:57:54.000000000 +0200
@@ -71,7 +71,7 @@ static inline int saa7146_wait_for_debi_
    if (saa7146_read(dev, MC2) & 2)
      break;
    if (err) {
-     pr_err("%s: %s timed out while waiting for registers getting
programmed\n",
+     pr_debug("%s: %s timed out while waiting for registers getting
programmed\n",
             dev->name, __func__);
      return -ETIMEDOUT;
    }