From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp-out-102.synserver.de ([212.40.185.102]:1399 "EHLO smtp-out-102.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001AbaJPMHs (ORCPT ); Thu, 16 Oct 2014 08:07:48 -0400 Message-ID: <543FB374.8020604@metafoo.de> Date: Thu, 16 Oct 2014 14:00:52 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 To: Shuah Khan , m.chehab@samsung.com, akpm@linux-foundation.org, gregkh@linuxfoundation.org, crope@iki.fi, olebowle@gmx.com, dheitmueller@kernellabs.com, hverkuil@xs4all.nl, ramakrmu@cisco.com, sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com, perex@perex.cz, tiwai@suse.de, prabhakar.csengg@gmail.com, tim.gardner@canonical.com, linux@eikelenboom.it CC: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-media@vger.kernel.org Subject: Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 10/14/2014 04:58 PM, Shuah Khan wrote: [...] > switch (cmd) { > case SNDRV_PCM_TRIGGER_START: > + err = media_get_audio_tkn(&subs->dev->dev); > + if (err == -EBUSY) { > + dev_info(&subs->dev->dev, "%s device is busy\n", > + __func__); In my opinion this should not dev_info() as this is out of band error signaling and also as the potential to spam the log. The userspace application is already properly notified by the return code. > + return err; > + } > err = start_endpoints(subs, false); > if (err < 0) > return err;