linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
	Kamil Debski <k.debski@samsung.com>,
	'Kiran AVND' <avnd.kiran@samsung.com>,
	linux-media@vger.kernel.org,
	'Mauro Carvalho Chehab' <m.chehab@samsung.com>,
	'Hans Verkuil' <hans.verkuil@cisco.com>,
	laurent.pinchart@ideasonboard.com
Cc: wuchengli@chromium.org, posciak@chromium.org, arun.m@samsung.com,
	ihf@chromium.org, prathyush.k@samsung.com, arun.kk@samsung.com,
	kiran@chromium.org, Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [PATCH v2 14/14] [media] s5p-mfc: Don't change the image size to smaller than the request.
Date: Tue, 21 Oct 2014 08:43:11 -0400	[thread overview]
Message-ID: <544654DF.4000201@collabora.com> (raw)
In-Reply-To: <544644D9.4020701@xs4all.nl>


Le 2014-10-21 07:34, Hans Verkuil a écrit :
>
> I think we should add flags here as well. NEAREST (the default), 
> ROUND_DOWN and
> ROUND_UP. Existing calls will use NEAREST. I can think of use-cases 
> for all
> three of these, and I think the caller should just have to specify 
> what is
> needed.
>
> Just replacing the algorithm used seems asking for problems, you want 
> to be
> able to select what you want to do. 

One more thing, we realize that in selection scenario, we do want 
nearest or lowest, so indeed a flag that let user space choose is the best.

Nicolas


  reply	other threads:[~2014-10-21 12:43 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-26  4:52 [PATCH v2 00/14] Fixes from Chrome OS tree for MFC driver Kiran AVND
2014-09-26  4:52 ` [PATCH v2 01/14] [media] s5p-mfc: support MIN_BUFFERS query for encoder Kiran AVND
2014-09-26  4:52 ` [PATCH v2 02/14] [media] s5p-mfc: Fix REQBUFS(0) " Kiran AVND
2014-09-26  4:52 ` [PATCH v2 03/14] [media] s5p-mfc: clear 'enter_suspend' flag if suspend fails Kiran AVND
2014-09-26  4:52 ` [PATCH v2 04/14] [media] s5p-mfc: Only set timestamp/timecode for new frames Kiran AVND
2014-09-26  4:52 ` [PATCH v2 05/14] [media] s5p-mfc: keep RISC ON during reset for V7/V8 Kiran AVND
2014-09-26  4:52 ` [PATCH v2 06/14] [media] s5p-mfc: check mfc bus ctrl before reset Kiran AVND
2014-09-26  4:52 ` [PATCH v2 07/14] [media] s5p-mfc: Don't crash the kernel if the watchdog kicks in Kiran AVND
2014-10-08 10:26   ` Kamil Debski
2014-10-21  8:50     ` Arun Kumar K
2014-09-26  4:52 ` [PATCH v2 08/14] [media] s5p-mfc: modify mfc wakeup sequence for V8 Kiran AVND
2014-09-26  4:52 ` [PATCH v2 09/14] [media] s5p-mfc: De-init MFC when watchdog kicks in Kiran AVND
2014-09-26  4:52 ` [PATCH v2 10/14] [media] s5p-mfc: flush dpbs when resolution changes Kiran AVND
2014-09-26  4:52 ` [PATCH v2 11/14] [media] s5p-mfc: Remove unused alloc field from private buffer struct Kiran AVND
2014-09-26  4:52 ` [PATCH v2 12/14] [media] s5p-mfc: fix V4L2_CID_MIN_BUFFERS_FOR_CAPTURE on resolution change Kiran AVND
2014-09-26  4:52 ` [PATCH v2 13/14] [media] s5p-mfc: fix a race in interrupt flags handling Kiran AVND
2014-10-08 10:29   ` Kamil Debski
2014-09-26  4:52 ` [PATCH v2 14/14] [media] s5p-mfc: Don't change the image size to smaller than the request Kiran AVND
2014-10-08 10:24   ` Kamil Debski
2014-10-08 14:34     ` Nicolas Dufresne
2014-10-09 10:06       ` Kamil Debski
2014-10-09 12:57         ` Nicolas Dufresne
2014-10-21 11:34         ` Hans Verkuil
2014-10-21 12:43           ` Nicolas Dufresne [this message]
2014-10-21 12:48           ` Kamil Debski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=544654DF.4000201@collabora.com \
    --to=nicolas.dufresne@collabora.com \
    --cc=a.hajda@samsung.com \
    --cc=arun.kk@samsung.com \
    --cc=arun.m@samsung.com \
    --cc=avnd.kiran@samsung.com \
    --cc=hans.verkuil@cisco.com \
    --cc=hverkuil@xs4all.nl \
    --cc=ihf@chromium.org \
    --cc=k.debski@samsung.com \
    --cc=kiran@chromium.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=posciak@chromium.org \
    --cc=prathyush.k@samsung.com \
    --cc=wuchengli@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).