From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:50318 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049AbaJZLSN (ORCPT ); Sun, 26 Oct 2014 07:18:13 -0400 Message-ID: <544CD873.7090600@iki.fi> Date: Sun, 26 Oct 2014 13:18:11 +0200 From: Antti Palosaari MIME-Version: 1.0 To: Olli Salonen , linux-media@vger.kernel.org Subject: Re: [PATCH] cxusb: TS mode setting for TT CT2-4400 References: <1414310172-25876-1-git-send-email-olli.salonen@iki.fi> In-Reply-To: <1414310172-25876-1-git-send-email-olli.salonen@iki.fi> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Reviewed-by: Antti Palosaari Antti On 10/26/2014 09:56 AM, Olli Salonen wrote: > There is a new version of the TechnoTrend CT2-4400 USB tuner. The difference is the demodulator that is used (Si2168-B40 instead of -A30). > > For TT CT2-4400v2 a TS stream related parameter needs to be set, otherwise the stream becomes corrupted. The Windows driver for both CT2-4400 and CT2-4400v2 sets this as well. After this patch the driver works for both versions. > > Signed-off-by: Olli Salonen > --- > drivers/media/usb/dvb-usb/cxusb.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/media/usb/dvb-usb/cxusb.c b/drivers/media/usb/dvb-usb/cxusb.c > index 356abb3..8925b3946 100644 > --- a/drivers/media/usb/dvb-usb/cxusb.c > +++ b/drivers/media/usb/dvb-usb/cxusb.c > @@ -1438,6 +1438,12 @@ static int cxusb_tt_ct2_4400_attach(struct dvb_usb_adapter *adap) > si2168_config.i2c_adapter = &adapter; > si2168_config.fe = &adap->fe_adap[0].fe; > si2168_config.ts_mode = SI2168_TS_PARALLEL; > + > + /* CT2-4400v2 TS gets corrupted without this */ > + if (d->udev->descriptor.idProduct == > + USB_PID_TECHNOTREND_TVSTICK_CT2_4400) > + si2168_config.ts_mode |= 0x40; > + > memset(&info, 0, sizeof(struct i2c_board_info)); > strlcpy(info.type, "si2168", I2C_NAME_SIZE); > info.addr = 0x64; > -- http://palosaari.fi/