From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-la0-f51.google.com ([209.85.215.51]:35367 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757649AbaJaNA2 (ORCPT ); Fri, 31 Oct 2014 09:00:28 -0400 Received: by mail-la0-f51.google.com with SMTP id q1so6089423lam.24 for ; Fri, 31 Oct 2014 06:00:26 -0700 (PDT) Message-ID: <545387E6.4020707@cogentembedded.com> Date: Fri, 31 Oct 2014 16:00:22 +0300 From: Sergei Shtylyov MIME-Version: 1.0 To: Yoshihiro Kaneko , linux-media@vger.kernel.org CC: Guennadi Liakhovetski , Simon Horman , Magnus Damm , linux-sh@vger.kernel.org Subject: Re: [PATCH] media: soc_camera: rcar_vin: Add BT.709 24-bit RGB888 input support References: <1414746490-23077-1-git-send-email-ykaneko0929@gmail.com> In-Reply-To: <1414746490-23077-1-git-send-email-ykaneko0929@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hello. On 10/31/2014 12:08 PM, Yoshihiro Kaneko wrote: > From: Koji Matsuoka > Signed-off-by: Koji Matsuoka > Signed-off-by: Simon Horman > Signed-off-by: Yoshihiro Kaneko > --- > This patch is against master branch of linuxtv.org/media_tree.git. > v3 [Yoshihiro Kaneko] > * fixes the detection of RGB input > v2 [Yoshihiro Kaneko] > * remove unused definition as suggested by Sergei Shtylyov > * use VNMC_INF_RGB888 directly instead of VNMC_INF_RGB_MASK as a bit-field > mask > drivers/media/platform/soc_camera/rcar_vin.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c > index 20defcb..18ce4bd 100644 > --- a/drivers/media/platform/soc_camera/rcar_vin.c > +++ b/drivers/media/platform/soc_camera/rcar_vin.c [...] > @@ -331,6 +336,15 @@ static int rcar_vin_setup(struct rcar_vin_priv *priv) > if (output_is_yuv) > vnmc |= VNMC_BPS; > > + /* Please indent with a tab, not spaces. > + * The above assumes YUV input, toggle BPS for RGB input. > + * RGB inputs can be detected by checking that the most-significant > + * two bits of INF are set. This corresponds to the bits > + * set in VNMC_INF_RGB888. > + */ > + if ((vnmc & VNMC_INF_RGB888)) == VNMC_INF_RGB888) > + vnmc ^= VNMC_BPS; > + > /* progressive or interlaced mode */ > interrupts = progressive ? VNIE_FIE | VNIE_EFE : VNIE_EFE; > WBR, Sergei