Re: [git:v4l-utils/master] libdvbv5, dvbv5-scan: generalize channel duplication check

Re: [git:v4l-utils/master] libdvbv5, dvbv5-scan: generalize channel duplication check

[Akihiro TSUKADA]

Hi,

After I re-checked the source,
I noticed that dvb_scan_add_entry() also breaks API/ABI compatibility
as well as dvb_new_freq_is_needed(), and those functions are
marked as "ancillary functions used internally inside the library"
in dvb-scan.h.
So I think it would rather be better to move those funcs to a private
header (dvb-scan-priv.h?).
Which way should we go? ver bump/compat-soname.c/dvb-scan-priv.h ?
--
Akihiro

Re: [git:v4l-utils/master] libdvbv5, dvbv5-scan: generalize channel duplication check

[Mauro Carvalho Chehab]

Em Sun, 02 Nov 2014 18:30:46 +0900
Akihiro TSUKADA <tskd08@gmail.com> escreveu:

> Hi,
> 
> After I re-checked the source,
> I noticed that dvb_scan_add_entry() also breaks API/ABI compatibility
> as well as dvb_new_freq_is_needed(), and those functions are
> marked as "ancillary functions used internally inside the library"
> in dvb-scan.h.
> So I think it would rather be better to move those funcs to a private
> header (dvb-scan-priv.h?).
> Which way should we go? ver bump/compat-soname.c/dvb-scan-priv.h ?

I would keep them exported. It shouldn't be hard to provide a backward
compatible function with the same name where the extra parameter would
be filled internally, and passed to a new function with one extra argument.

Regards,
Mauro

Re: [git:v4l-utils/master] libdvbv5, dvbv5-scan: generalize channel duplication check

[Gregor Jasny]

On 02/11/14 10:41, Mauro Carvalho Chehab wrote:
> Em Sun, 02 Nov 2014 18:30:46 +0900
> Akihiro TSUKADA <tskd08@gmail.com> escreveu:
> 
>> Hi,
>>
>> After I re-checked the source,
>> I noticed that dvb_scan_add_entry() also breaks API/ABI compatibility
>> as well as dvb_new_freq_is_needed(), and those functions are
>> marked as "ancillary functions used internally inside the library"
>> in dvb-scan.h.
>> So I think it would rather be better to move those funcs to a private
>> header (dvb-scan-priv.h?).
>> Which way should we go? ver bump/compat-soname.c/dvb-scan-priv.h ?
> 
> I would keep them exported. It shouldn't be hard to provide a backward
> compatible function with the same name where the extra parameter would
> be filled internally, and passed to a new function with one extra argument.

As far as I understand dvb-scan uses these functions, so they are not
that internal like intended. Providing a backward compatible function
would be the way to go.

FYI: The Ubuntu buildbot discovered the breakage:
> https://launchpad.net/~libv4l/+archive/ubuntu/development/+build/6528719/+files/buildlog_ubuntu-trusty-i386.v4l-utils_1.6.0%2Br2607-66%7Eubuntu14.04.1_FAILEDTOBUILD.txt.gz

Thanks,
-Gregor