* Re: [git:v4l-utils/master] libdvbv5, dvbv5-scan: generalize channel duplication check [not found] ` <54556AC9.40309@googlemail.com> @ 2014-11-02 9:30 ` Akihiro TSUKADA 2014-11-02 9:41 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 3+ messages in thread From: Akihiro TSUKADA @ 2014-11-02 9:30 UTC (permalink / raw) To: Gregor Jasny, Mauro Carvalho Chehab; +Cc: linux-media Hi, After I re-checked the source, I noticed that dvb_scan_add_entry() also breaks API/ABI compatibility as well as dvb_new_freq_is_needed(), and those functions are marked as "ancillary functions used internally inside the library" in dvb-scan.h. So I think it would rather be better to move those funcs to a private header (dvb-scan-priv.h?). Which way should we go? ver bump/compat-soname.c/dvb-scan-priv.h ? -- Akihiro ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [git:v4l-utils/master] libdvbv5, dvbv5-scan: generalize channel duplication check 2014-11-02 9:30 ` [git:v4l-utils/master] libdvbv5, dvbv5-scan: generalize channel duplication check Akihiro TSUKADA @ 2014-11-02 9:41 ` Mauro Carvalho Chehab 2014-11-02 10:18 ` Gregor Jasny 0 siblings, 1 reply; 3+ messages in thread From: Mauro Carvalho Chehab @ 2014-11-02 9:41 UTC (permalink / raw) To: Akihiro TSUKADA; +Cc: Gregor Jasny, linux-media Em Sun, 02 Nov 2014 18:30:46 +0900 Akihiro TSUKADA <tskd08@gmail.com> escreveu: > Hi, > > After I re-checked the source, > I noticed that dvb_scan_add_entry() also breaks API/ABI compatibility > as well as dvb_new_freq_is_needed(), and those functions are > marked as "ancillary functions used internally inside the library" > in dvb-scan.h. > So I think it would rather be better to move those funcs to a private > header (dvb-scan-priv.h?). > Which way should we go? ver bump/compat-soname.c/dvb-scan-priv.h ? I would keep them exported. It shouldn't be hard to provide a backward compatible function with the same name where the extra parameter would be filled internally, and passed to a new function with one extra argument. Regards, Mauro ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [git:v4l-utils/master] libdvbv5, dvbv5-scan: generalize channel duplication check 2014-11-02 9:41 ` Mauro Carvalho Chehab @ 2014-11-02 10:18 ` Gregor Jasny 0 siblings, 0 replies; 3+ messages in thread From: Gregor Jasny @ 2014-11-02 10:18 UTC (permalink / raw) To: Mauro Carvalho Chehab, Akihiro TSUKADA; +Cc: linux-media On 02/11/14 10:41, Mauro Carvalho Chehab wrote: > Em Sun, 02 Nov 2014 18:30:46 +0900 > Akihiro TSUKADA <tskd08@gmail.com> escreveu: > >> Hi, >> >> After I re-checked the source, >> I noticed that dvb_scan_add_entry() also breaks API/ABI compatibility >> as well as dvb_new_freq_is_needed(), and those functions are >> marked as "ancillary functions used internally inside the library" >> in dvb-scan.h. >> So I think it would rather be better to move those funcs to a private >> header (dvb-scan-priv.h?). >> Which way should we go? ver bump/compat-soname.c/dvb-scan-priv.h ? > > I would keep them exported. It shouldn't be hard to provide a backward > compatible function with the same name where the extra parameter would > be filled internally, and passed to a new function with one extra argument. As far as I understand dvb-scan uses these functions, so they are not that internal like intended. Providing a backward compatible function would be the way to go. FYI: The Ubuntu buildbot discovered the breakage: > https://launchpad.net/~libv4l/+archive/ubuntu/development/+build/6528719/+files/buildlog_ubuntu-trusty-i386.v4l-utils_1.6.0%2Br2607-66%7Eubuntu14.04.1_FAILEDTOBUILD.txt.gz Thanks, -Gregor ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-02 10:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1XkI3i-00082l-Jd@www.linuxtv.org>
[not found] ` <54556AC9.40309@googlemail.com>
2014-11-02 9:30 ` [git:v4l-utils/master] libdvbv5, dvbv5-scan: generalize channel duplication check Akihiro TSUKADA
2014-11-02 9:41 ` Mauro Carvalho Chehab
2014-11-02 10:18 ` Gregor Jasny
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).