From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:20573 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912AbaKRIJR (ORCPT ); Tue, 18 Nov 2014 03:09:17 -0500 Message-id: <546AFEA5.9020000@samsung.com> Date: Tue, 18 Nov 2014 09:09:09 +0100 From: Jacek Anaszewski MIME-version: 1.0 To: Sakari Ailus , Pavel Machek Cc: pali.rohar@gmail.com, sre@debian.org, sre@ring0.de, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, freemangordon@abv.bg, bcousson@baylibre.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [RFC] adp1653: Add device tree bindings for LED controller References: <20141116075928.GA9763@amd> <20141117145857.GO8907@valkosipuli.retiisi.org.uk> In-reply-to: <20141117145857.GO8907@valkosipuli.retiisi.org.uk> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Pavel, Sakari, On 11/17/2014 03:58 PM, Sakari Ailus wrote: > Hi Pavel, > > On Sun, Nov 16, 2014 at 08:59:28AM +0100, Pavel Machek wrote: >> For device tree people: Yes, I know I'll have to create file in >> documentation, but does the binding below look acceptable? >> >> I'll clean up driver code a bit more, remove the printks. Anything >> else obviously wrong? > > Jacek Anaszewski is working on flash support for LED devices. I think it'd > be good to sync the DT bindings for the two, as the types of devices > supported by the LED API and the V4L2 flash API are quite similar. > > Cc Jacek. I've already submitted a patch [1] that updates leds common bindings. I hasn't been merged yet, as the related LED Flash class patch [2] still needs some indicator leds related discussion [3]. I think this is a good moment to discuss the flash related led common bindings. [1] http://www.spinics.net/lists/linux-leds/msg02121.html [2] http://www.spinics.net/lists/linux-media/msg83100.html [3] http://www.spinics.net/lists/linux-leds/msg02472.html Best Regards, Jacek Anaszewski