From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:20284 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750885AbaKTMsc (ORCPT ); Thu, 20 Nov 2014 07:48:32 -0500 Message-id: <546DE31B.20602@samsung.com> Date: Thu, 20 Nov 2014 13:48:27 +0100 From: Jacek Anaszewski MIME-version: 1.0 To: Pavel Machek Cc: Sakari Ailus , pali.rohar@gmail.com, sre@debian.org, sre@ring0.de, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, freemangordon@abv.bg, bcousson@baylibre.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org, Linux LED Subsystem Subject: Re: [RFC] adp1653: Add device tree bindings for LED controller References: <20141117145857.GO8907@valkosipuli.retiisi.org.uk> <546AFEA5.9020000@samsung.com> <20141118084603.GC4059@amd> <546B19C8.2090008@samsung.com> <20141118113256.GA10022@amd> <546B40FA.2070409@samsung.com> <20141118132159.GA21089@amd> <546B6D86.8090701@samsung.com> <20141118165148.GA11711@amd> <546C66A5.6060201@samsung.com> <20141120121202.GA27527@amd> In-reply-to: <20141120121202.GA27527@amd> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Pavel, On 11/20/2014 01:12 PM, Pavel Machek wrote: > Hi! > >> I would also swap the segments of a property name to follow the convention >> as in case of "regulator-max-microamp". >> >> Updated version: >> >> ========================================================== >> >> Optional properties for child nodes: >> - max-microamp : maximum intensity in microamperes of the LED >> (torch LED for flash devices) >> - flash-max-microamp : maximum intensity in microamperes of the >> flash LED; it is mandatory if the led should >> support the flash mode >> - flash-timeout-microsec : timeout in microseconds after which the flash >> led is turned off > > Works for me. Do you want to submit a patch or should I do it? You can submit a patch for leds/common.txt and a separate patch for the adp1653 with a reference to the leds/common.txt for the child nodes. > >> - indicator-pattern : identifier of the blinking pattern for the >> indicator led >> > > This would need a bit more documentation, no? - indicator-pattern : identifier of the blinking pattern for the indicator led; valid identifiers should be defined in the documentation of the parent node. I wouldn't go for pre-defined identifiers as the pattern can be a combination of various settings like ramp-up, ramp-down, pulse time etc. Drivers should expose only few combinations of these settings in my opinion, like e.g. leds-lm355x.c does. Regards, Jacek