linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Antti Palosaari <crope@iki.fi>
To: Olli Salonen <olli.salonen@iki.fi>, linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2] si2168: add support for firmware files in new format
Date: Fri, 28 Nov 2014 00:12:37 +0200	[thread overview]
Message-ID: <5477A1D5.70505@iki.fi> (raw)
In-Reply-To: <1417117343-1793-2-git-send-email-olli.salonen@iki.fi>

On 11/27/2014 09:42 PM, Olli Salonen wrote:
> This patch adds support for new type of firmware versions of Si2168 chip.
>
> Old type: n x 8 bytes (all data, first byte seems to be 04 or 05)
> New type: n x 17 bytes (1 byte indicates len and max 16 bytes data)
>
> New version of TechnoTrend CT2-4400 drivers
> (http://www.tt-downloads.de/bda-treiber_4.3.0.0.zip) contains newer
> firmware for Si2168-B40 that is in the new format. It can be extracted
> with the following command:
>
> dd if=ttTVStick4400_64.sys ibs=1 skip=323872 count=6919 of=dvb-demod-si2168-b40-01.fw
>
> Signed-off-by: Olli Salonen <olli.salonen@iki.fi>

Reviewed-by: Antti Palosaari <crope@iki.fi>

That change makes anyhow some headache on case driver is old and does 
not support that newer firmware format... On that case it fails and 
error is printed, though. But we can live with it as there is no 
regression - kernel update is still possible. Only kernel downgrade 
could cause problem if new format firmware is installed.

regards
Antti

-- 
http://palosaari.fi/

  reply	other threads:[~2014-11-27 22:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27 19:42 [PATCH 1/2] si2168: debug printout for firmware version Olli Salonen
2014-11-27 19:42 ` [PATCH 2/2] si2168: add support for firmware files in new format Olli Salonen
2014-11-27 22:12   ` Antti Palosaari [this message]
2014-11-27 21:49 ` [PATCH 1/2] si2168: debug printout for firmware version Antti Palosaari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5477A1D5.70505@iki.fi \
    --to=crope@iki.fi \
    --cc=linux-media@vger.kernel.org \
    --cc=olli.salonen@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).