From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org
Cc: Michal Simek <michal.simek@xilinx.com>,
Chris Kohn <christian.kohn@xilinx.com>,
Hyun Kwon <hyun.kwon@xilinx.com>
Subject: Re: [PATCH v4 07/10] v4l: vb2: Fix race condition in _vb2_fop_release
Date: Wed, 03 Dec 2014 16:07:15 +0100 [thread overview]
Message-ID: <547F2723.5070907@samsung.com> (raw)
In-Reply-To: <1417464820-6718-8-git-send-email-laurent.pinchart@ideasonboard.com>
On 01/12/14 21:13, Laurent Pinchart wrote:
> The function releases the queue if the file being released is the queue
> owner. The check reads the queue->owner field without taking the queue
> lock, creating a race condition with functions that set the queue owner,
> such as vb2_ioctl_reqbufs() for instance.
>
> Fix this by moving the queue->owner check within the mutex protected
> section.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
next prev parent reply other threads:[~2014-12-03 15:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 20:13 [PATCH v4 00/10] Xilinx Video IP Core support Laurent Pinchart
2014-12-01 20:13 ` [PATCH v4 01/10] media: entity: Document the media_entity_ops structure Laurent Pinchart
2014-12-01 20:13 ` [PATCH v4 02/10] v4l: Add RBG and RGB 8:8:8 media bus formats on 24 and 32 bit busses Laurent Pinchart
2014-12-01 20:13 ` [PATCH v4 03/10] v4l: Sort YUV formats of v4l2_mbus_pixelcode Laurent Pinchart
2014-12-01 20:13 ` [PATCH v4 04/10] v4l: Add VUY8 24 bits bus format Laurent Pinchart
2014-12-01 20:13 ` [PATCH v4 05/10] v4l: of: Add v4l2_of_parse_link() function Laurent Pinchart
2014-12-03 12:30 ` Sakari Ailus
2014-12-03 15:02 ` Sylwester Nawrocki
2014-12-03 15:10 ` Laurent Pinchart
2014-12-01 20:13 ` [PATCH v4 06/10] v4l: vb2: Fix race condition in vb2_fop_poll Laurent Pinchart
2014-12-01 20:13 ` [PATCH v4 07/10] v4l: vb2: Fix race condition in _vb2_fop_release Laurent Pinchart
2014-12-03 15:07 ` Sylwester Nawrocki [this message]
2014-12-01 20:13 ` [PATCH v4 08/10] v4l: xilinx: Add Xilinx Video IP core Laurent Pinchart
2015-01-22 3:01 ` Laurent Pinchart
2015-01-22 9:43 ` Hans Verkuil
2015-01-26 19:37 ` Chris Kohn
2014-12-01 20:13 ` [PATCH v4 09/10] v4l: xilinx: Add Video Timing Controller driver Laurent Pinchart
2014-12-01 20:13 ` [PATCH v4 10/10] v4l: xilinx: Add Test Pattern Generator driver Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547F2723.5070907@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=christian.kohn@xilinx.com \
--cc=hyun.kwon@xilinx.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox