From: Antti Palosaari <crope@iki.fi>
To: Benjamin Larsson <benjamin@southpole.se>, unlisted-recipients:;
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 2/3] mn88472: make sure the private data struct is nulled after free
Date: Sat, 06 Dec 2014 18:29:27 +0200 [thread overview]
Message-ID: <54832EE7.10705@iki.fi> (raw)
In-Reply-To: <1417825533-13081-2-git-send-email-benjamin@southpole.se>
But that is not needed anymore ?
regards
Antti
On 12/06/2014 02:25 AM, Benjamin Larsson wrote:
> Using this driver with the attach dvb model might trigger a use
> after free when unloading the driver. With this change the driver
> will always fail on unload instead of randomly crash depending
> on if the memory has been reused or not.
>
> Signed-off-by: Benjamin Larsson <benjamin@southpole.se>
> ---
> drivers/staging/media/mn88472/mn88472.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c
> index 36ef39b..a9d5f0a 100644
> --- a/drivers/staging/media/mn88472/mn88472.c
> +++ b/drivers/staging/media/mn88472/mn88472.c
> @@ -489,6 +489,7 @@ static int mn88472_remove(struct i2c_client *client)
>
> regmap_exit(dev->regmap[0]);
>
> + memset(dev, 0, sizeof(*dev));
> kfree(dev);
>
> return 0;
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-12-06 16:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 0:25 [PATCH 1/3] rtl28xxu: lower the rc poll time to mitigate i2c transfer errors Benjamin Larsson
2014-12-06 0:25 ` [PATCH 2/3] mn88472: make sure the private data struct is nulled after free Benjamin Larsson
2014-12-06 16:29 ` Antti Palosaari [this message]
2014-12-06 18:08 ` Benjamin Larsson
2014-12-06 18:37 ` Antti Palosaari
2014-12-06 20:26 ` Benjamin Larsson
2015-01-19 13:15 ` Hans Verkuil
2015-01-19 18:38 ` Benjamin Larsson
2014-12-06 0:25 ` [PATCH 3/3] mn88472: add ts mode and ts clock to driver Benjamin Larsson
2014-12-06 16:31 ` Antti Palosaari
2014-12-06 12:46 ` [PATCH 1/3] rtl28xxu: lower the rc poll time to mitigate i2c transfer errors Antti Palosaari
2014-12-06 14:27 ` Benjamin Larsson
2015-02-19 9:44 ` Benjamin Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54832EE7.10705@iki.fi \
--to=crope@iki.fi \
--cc=benjamin@southpole.se \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox