From: Benjamin Larsson <benjamin@southpole.se>
To: Antti Palosaari <crope@iki.fi>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 2/2] mn88472: fix firmware loading
Date: Mon, 08 Dec 2014 17:04:30 +0100 [thread overview]
Message-ID: <5485CC0E.2090201@southpole.se> (raw)
In-Reply-To: <5484D666.6060605@iki.fi>
On 12/07/2014 11:36 PM, Antti Palosaari wrote:
> On 12/08/2014 12:10 AM, Benjamin Larsson wrote:
>> The firmware must be loaded one byte at a time via the 0xf6 register.
>
> I don't think so. Currently it downloads firmware in 22 byte chunks
> and it seems to work, at least for me, both mn88472 and mn88473.
Ok, I have now tried the driver with my defaults patch in and with your
method of loading the firmware and my patch. I have my antenna placed in
a bad location with bad reception. With my patch I am getting data from
the device, without my patch I am not. So whatever my code does it makes
the device more sensitive.
And then there is this comment in the regmap code:
regmap_bulk_write(): Write multiple registers to the device
In this case we want to write multiple bytes to the same register. So I
think that my patch is correct in principle.
MvH
Benjamin Larsson
next prev parent reply other threads:[~2014-12-08 16:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-07 22:10 [PATCH 1/2] mn88472: load demodulator register defaults Benjamin Larsson
2014-12-07 22:10 ` [PATCH 2/2] mn88472: fix firmware loading Benjamin Larsson
2014-12-07 22:36 ` Antti Palosaari
2014-12-08 11:12 ` Benjamin Larsson
2014-12-08 17:35 ` Antti Palosaari
2014-12-08 16:04 ` Benjamin Larsson [this message]
2014-12-08 17:46 ` Antti Palosaari
2014-12-08 18:54 ` Benjamin Larsson
2014-12-07 22:25 ` [PATCH 1/2] mn88472: load demodulator register defaults Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5485CC0E.2090201@southpole.se \
--to=benjamin@southpole.se \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox