From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:60848 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934184AbaLKI7R (ORCPT ); Thu, 11 Dec 2014 03:59:17 -0500 Message-ID: <54895C92.9000007@xs4all.nl> Date: Thu, 11 Dec 2014 09:57:54 +0100 From: Hans Verkuil MIME-Version: 1.0 To: linux-media@vger.kernel.org CC: marbugge@cisco.com, dri-devel@lists.freedesktop.org, thierry.reding@gmail.com Subject: Re: [PATCHv2 0/3] hdmi: add unpack and logging functions References: <1417522126-31771-1-git-send-email-hverkuil@xs4all.nl> In-Reply-To: <1417522126-31771-1-git-send-email-hverkuil@xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Thierry, On 12/02/14 13:08, Hans Verkuil wrote: > This patch series adds new HDMI 2.0/CEA-861-F defines to hdmi.h and > adds unpacking and logging functions to hdmi.c. It also uses those > in the V4L2 adv7842 driver (and they will be used in other HDMI drivers > once this functionality is merged). > > Patches 2 and 3 have been posted before by Martin Bugge. It stalled, but > I am taking over from Martin to try and get this is. I want to use this > in a bunch of v4l2 drivers, so I would really like to see this merged. > > Changes since v1: > > - rename HDMI_CONTENT_TYPE_NONE to HDMI_CONTENT_TYPE_GRAPHICS to conform > to CEA-861-F. > - added missing HDMI_AUDIO_CODING_TYPE_CXT. > - Be explicit: out of range values are called "Invalid", reserved > values are called "Reserved". > - Incorporated most of Thierry's suggestions. Exception: I didn't > create ..._get_name(buffer, length, ...) functions. I think it makes > the API awkward and I am not convinced that it is that useful. > I also kept "No Data" since that's what CEA-861-F calls it. I also > think that "No Data" is a better description than "None" since it > really means that nobody bothered to fill this in. > > Please let me know if there are more things that need to be addressed in > these patches before they can be merged. Any comments about this v2? If not, is this something you or someone else from dri-devel will take, or can it be merged through the media git repository? Regards, Hans