From: Antti Palosaari <crope@iki.fi>
To: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH 06/10] hd29l2: fix sparse error and warnings
Date: Sat, 13 Dec 2014 15:25:05 +0200 [thread overview]
Message-ID: <548C3E31.2040103@iki.fi> (raw)
In-Reply-To: <1418471580-26510-7-git-send-email-hverkuil@xs4all.nl>
On 12/13/2014 01:52 PM, Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> drivers/media/dvb-frontends/hd29l2.c:29:18: warning: Variable length array is used.
> drivers/media/dvb-frontends/hd29l2.c:34:32: error: cannot size expression
> drivers/media/dvb-frontends/hd29l2.c:125:5: warning: symbol 'hd29l2_rd_reg_mask' was not declared. Should it be static?
>
> Variable length arrays are frowned upon, so replace with a fixed length and check
> that there won't be a buffer overrun.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-12-13 13:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-13 11:52 [PATCH 00/10] Sparse fixes Hans Verkuil
2014-12-13 11:52 ` [PATCH 01/10] av7110: fix sparse warning Hans Verkuil
2014-12-13 11:52 ` [PATCH 02/10] budget-core: fix sparse warnings Hans Verkuil
2014-12-13 11:52 ` [PATCH 03/10] ivtv: fix sparse warning Hans Verkuil
2014-12-13 11:52 ` [PATCH 04/10] videobuf2-vmalloc: " Hans Verkuil
2014-12-13 11:52 ` [PATCH 05/10] media-entity: fix sparse warnings Hans Verkuil
2014-12-13 12:08 ` Sakari Ailus
2014-12-13 11:52 ` [PATCH 06/10] hd29l2: fix sparse error and warnings Hans Verkuil
2014-12-13 13:25 ` Antti Palosaari [this message]
2014-12-13 11:52 ` [PATCH 07/10] m5mols: fix sparse warnings Hans Verkuil
2014-12-15 10:56 ` Sylwester Nawrocki
2014-12-13 11:52 ` [PATCH 08/10] s5k4ecgx: " Hans Verkuil
2014-12-15 10:56 ` Sylwester Nawrocki
2014-12-13 11:52 ` [PATCH 09/10] s5k6aa: " Hans Verkuil
2014-12-15 10:58 ` Sylwester Nawrocki
2014-12-13 11:53 ` [PATCH 10/10] s5k5baf: " Hans Verkuil
2014-12-15 10:59 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548C3E31.2040103@iki.fi \
--to=crope@iki.fi \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).