From: Antti Palosaari <crope@iki.fi>
To: Benjamin Larsson <benjamin@southpole.se>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [RFC][PATCH] mn88472: add support for the mn88473 demod
Date: Sun, 21 Dec 2014 11:21:06 +0200 [thread overview]
Message-ID: <54969102.3030204@iki.fi> (raw)
In-Reply-To: <54960F0C.5020506@southpole.se>
Moikka!
On 12/21/2014 02:06 AM, Benjamin Larsson wrote:
> This is what mn88473 support in the mn88472 demod driver could look
> like. The code is untested but will look similar in the final version.
> It is also possible to let the driver figure out the demod version from
> the 0xff register. Then the users would not need to set that parameter.
> Same goes to the xtal parameter.
>
> So does the mn88473 support look ok and should the driver figure out
> what demod is connected ?
You patch looks rather good and these drivers should be merged to one if
possible, lets say registers are 80% same or something like that. Looks
like those are.
About detecting the chip type. Prefer always detecting automatically be
reading the chip id.
Second best way is to use device ID for that:
static const struct i2c_device_id mn88472_id_table[] = {
{"mn88472", 0},
{"mn88473", 1},
{}
Put the xtal/clock freq to config struct or use clock framework for it
(maybe too heavy solution).
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-12-21 9:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 23:57 [RFC][PATCH] mn88472: add support for the mn88473 demod Benjamin Larsson
2014-12-21 0:06 ` Benjamin Larsson
2014-12-21 9:21 ` Antti Palosaari [this message]
2014-12-30 23:23 ` Benjamin Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54969102.3030204@iki.fi \
--to=crope@iki.fi \
--cc=benjamin@southpole.se \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).