From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga11.intel.com ([192.55.52.93]:14864 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753226AbbAGOJH (ORCPT ); Wed, 7 Jan 2015 09:09:07 -0500 Message-ID: <54AD3E00.5070208@linux.intel.com> Date: Wed, 07 Jan 2015 16:09:04 +0200 From: Sakari Ailus MIME-Version: 1.0 To: Mauro Carvalho Chehab , Laurent Pinchart CC: Linux Media Mailing List , Mauro Carvalho Chehab , linux-api@vger.kernel.org Subject: Re: [PATCHv3 01/20] media: add new types for DVB devnodes References: <7f1ea82b1055aa490726f3af2ad22bca25e49a28.1420578087.git.mchehab@osg.samsung.com> In-Reply-To: <7f1ea82b1055aa490726f3af2ad22bca25e49a28.1420578087.git.mchehab@osg.samsung.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Mauro, Mauro Carvalho Chehab wrote: > Most of the DVB subdevs have already their own devnode. > > Add support for them at the media controller API. > > Signed-off-by: Mauro Carvalho Chehab > > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index 7902e800f019..707db275f92b 100644 > --- a/include/uapi/linux/media.h > +++ b/include/uapi/linux/media.h > @@ -50,7 +50,14 @@ struct media_device_info { > #define MEDIA_ENT_T_DEVNODE_V4L (MEDIA_ENT_T_DEVNODE + 1) > #define MEDIA_ENT_T_DEVNODE_FB (MEDIA_ENT_T_DEVNODE + 2) > #define MEDIA_ENT_T_DEVNODE_ALSA (MEDIA_ENT_T_DEVNODE + 3) > -#define MEDIA_ENT_T_DEVNODE_DVB (MEDIA_ENT_T_DEVNODE + 4) > +#define MEDIA_ENT_T_DEVNODE_DVB_FE (MEDIA_ENT_T_DEVNODE + 4) > +#define MEDIA_ENT_T_DEVNODE_DVB_DEMUX (MEDIA_ENT_T_DEVNODE + 5) > +#define MEDIA_ENT_T_DEVNODE_DVB_DVR (MEDIA_ENT_T_DEVNODE + 6) > +#define MEDIA_ENT_T_DEVNODE_DVB_CA (MEDIA_ENT_T_DEVNODE + 7) > +#define MEDIA_ENT_T_DEVNODE_DVB_NET (MEDIA_ENT_T_DEVNODE + 8) I'd create another type for the DVB sub-type devices, as there is for V4L2 sub-devices. I wonder what Laurent thinks. > + > +/* Legacy symbol. Use it to avoid userspace compilation breakages */ > +#define MEDIA_ENT_T_DEVNODE_DVB MEDIA_ENT_T_DEVNODE_DVB_FE > > #define MEDIA_ENT_T_V4L2_SUBDEV (2 << MEDIA_ENT_TYPE_SHIFT) > #define MEDIA_ENT_T_V4L2_SUBDEV_SENSOR (MEDIA_ENT_T_V4L2_SUBDEV + 1) > -- Kind regards, Sakari Ailus sakari.ailus@linux.intel.com