From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb1-smtp-cloud6.xs4all.net ([194.109.24.24]:40504 "EHLO lb1-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752130AbbASMtZ (ORCPT ); Mon, 19 Jan 2015 07:49:25 -0500 Message-ID: <54BCFD3F.1090009@xs4all.nl> Date: Mon, 19 Jan 2015 13:49:03 +0100 From: Hans Verkuil MIME-Version: 1.0 To: Antti Palosaari , linux-media@vger.kernel.org Subject: Re: [PATCH 01/66] dvb-usb-v2: add pointer to 'struct usb_interface' for driver usage References: <1419367799-14263-1-git-send-email-crope@iki.fi> In-Reply-To: <1419367799-14263-1-git-send-email-crope@iki.fi> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Antti, I'll mark this whole patch series as 'Accepted' in patchwork. It looks OK to me, and that way patchwork is cleaned up with only your pull request remaining. For whatever it is worth: Acked-by: Hans Verkuil Regards, Hans On 12/23/2014 09:48 PM, Antti Palosaari wrote: > Top level pointer on USB probe is struct usb_interface *. Add that > pointer to struct dvb_usb_device that drivers could use it, for > dev_* logging and more. > > Signed-off-by: Antti Palosaari > --- > drivers/media/usb/dvb-usb-v2/dvb_usb.h | 2 ++ > drivers/media/usb/dvb-usb-v2/dvb_usb_core.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/drivers/media/usb/dvb-usb-v2/dvb_usb.h b/drivers/media/usb/dvb-usb-v2/dvb_usb.h > index 14e111e..41c6363 100644 > --- a/drivers/media/usb/dvb-usb-v2/dvb_usb.h > +++ b/drivers/media/usb/dvb-usb-v2/dvb_usb.h > @@ -354,6 +354,7 @@ struct dvb_usb_adapter { > * @name: device name > * @rc_map: name of rc codes table > * @rc_polling_active: set when RC polling is active > + * @intf: pointer to the device's struct usb_interface > * @udev: pointer to the device's struct usb_device > * @rc: remote controller configuration > * @powered: indicated whether the device is power or not > @@ -370,6 +371,7 @@ struct dvb_usb_device { > const char *name; > const char *rc_map; > bool rc_polling_active; > + struct usb_interface *intf; > struct usb_device *udev; > struct dvb_usb_rc rc; > int powered; > diff --git a/drivers/media/usb/dvb-usb-v2/dvb_usb_core.c b/drivers/media/usb/dvb-usb-v2/dvb_usb_core.c > index 1950f37..9913e0f 100644 > --- a/drivers/media/usb/dvb-usb-v2/dvb_usb_core.c > +++ b/drivers/media/usb/dvb-usb-v2/dvb_usb_core.c > @@ -868,6 +868,7 @@ int dvb_usbv2_probe(struct usb_interface *intf, > goto err; > } > > + d->intf = intf; > d->name = driver_info->name; > d->rc_map = driver_info->rc_map; > d->udev = udev; >