From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb1-smtp-cloud6.xs4all.net ([194.109.24.24]:33090 "EHLO lb1-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751791AbbASN2H (ORCPT ); Mon, 19 Jan 2015 08:28:07 -0500 Message-ID: <54BD0651.1000508@xs4all.nl> Date: Mon, 19 Jan 2015 14:27:45 +0100 From: Hans Verkuil MIME-Version: 1.0 To: Antti Palosaari , linux-media@vger.kernel.org Subject: Re: [PATCH 01/22] si2168: define symbol rate limits References: <1417901696-5517-1-git-send-email-crope@iki.fi> <54BD0573.3020207@xs4all.nl> In-Reply-To: <54BD0573.3020207@xs4all.nl> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 01/19/2015 02:24 PM, Hans Verkuil wrote: > On 12/06/2014 10:34 PM, Antti Palosaari wrote: >> w_scan complains about missing symbol rate limits: >> This dvb driver is *buggy*: the symbol rate limits are undefined - please report to linuxtv.org >> >> Chip supports 1 to 7.2 MSymbol/s on DVB-C. >> >> Signed-off-by: Antti Palosaari > > Antti, > > Are you planning to make a pull request of this patch series? Never mind, I found the pull request :-) I'll mark these patches as accepted in patchwork, to keep patchwork clean. Regards, Hans > > It looks good to me, so for this patch series: > > Acked-by: Hans Verkuil > > BTW, please add a cover letter whenever you post a patch series (git send-email --compose). > It makes it easier to get an overview of what the patch series is all about. > > Regards, > > Hans > >> --- >> drivers/media/dvb-frontends/si2168.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c >> index ce9ab44..acf0fc3 100644 >> --- a/drivers/media/dvb-frontends/si2168.c >> +++ b/drivers/media/dvb-frontends/si2168.c >> @@ -635,6 +635,8 @@ static const struct dvb_frontend_ops si2168_ops = { >> .delsys = {SYS_DVBT, SYS_DVBT2, SYS_DVBC_ANNEX_A}, >> .info = { >> .name = "Silicon Labs Si2168", >> + .symbol_rate_min = 1000000, >> + .symbol_rate_max = 7200000, >> .caps = FE_CAN_FEC_1_2 | >> FE_CAN_FEC_2_3 | >> FE_CAN_FEC_3_4 | >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >