From: Hans Verkuil <hverkuil@xs4all.nl>
To: Antti Palosaari <crope@iki.fi>, linux-media@vger.kernel.org
Subject: Re: [PATCH 01/22] si2168: define symbol rate limits
Date: Mon, 19 Jan 2015 14:37:20 +0100 [thread overview]
Message-ID: <54BD0890.8040606@xs4all.nl> (raw)
In-Reply-To: <54BD06EC.4090209@iki.fi>
On 01/19/2015 02:30 PM, Antti Palosaari wrote:
> Moikka!
>
> On 01/19/2015 03:24 PM, Hans Verkuil wrote:
>> On 12/06/2014 10:34 PM, Antti Palosaari wrote:
>>> w_scan complains about missing symbol rate limits:
>>> This dvb driver is *buggy*: the symbol rate limits are undefined - please report to linuxtv.org
>>>
>>> Chip supports 1 to 7.2 MSymbol/s on DVB-C.
>>>
>>> Signed-off-by: Antti Palosaari <crope@iki.fi>
>>
>> Antti,
>>
>> Are you planning to make a pull request of this patch series?
>>
>> It looks good to me, so for this patch series:
>>
>> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
>>
>> BTW, please add a cover letter whenever you post a patch series (git send-email --compose).
>> It makes it easier to get an overview of what the patch series is all about.
>
> PULL request is here:
> https://patchwork.linuxtv.org/patch/27416/
>
> I could send new one if needed, there is missing branch name (new Git
> version has started blaming it).
It's probably wise to do that (and rebase at the same time).
>
> Are you applying these pull request now? I was expecting Mauro...
I'm cleaning up patchwork, and your (very long) patch series were making it
hard to work with patchwork.
Regards,
Hans
>
> regards
> Antti
>
prev parent reply other threads:[~2015-01-19 13:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 21:34 [PATCH 01/22] si2168: define symbol rate limits Antti Palosaari
2014-12-06 21:34 ` [PATCH 02/22] si2168: rename device state variable from 's' to 'dev' Antti Palosaari
2014-12-06 21:34 ` [PATCH 03/22] si2168: carry pointer to client instead of state Antti Palosaari
2014-12-06 21:34 ` [PATCH 04/22] si2168: get rid of own struct i2c_client pointer Antti Palosaari
2014-12-06 21:34 ` [PATCH 05/22] si2168: simplify si2168_cmd_execute() error path Antti Palosaari
2014-12-06 21:34 ` [PATCH 06/22] si2168: rename few things Antti Palosaari
2014-12-06 21:34 ` [PATCH 07/22] si2168: change firmware version print from debug to info Antti Palosaari
2014-12-06 21:34 ` [PATCH 08/22] si2168: change stream id debug log formatter Antti Palosaari
2014-12-06 21:34 ` [PATCH 09/22] si2168: add own goto label for kzalloc failure Antti Palosaari
2014-12-06 21:34 ` [PATCH 10/22] si2168: enhance firmware download routine Antti Palosaari
2014-12-06 21:34 ` [PATCH 11/22] si2168: remove unneeded fw variable initialization Antti Palosaari
2014-12-06 21:34 ` [PATCH 12/22] si2168: print chip version Antti Palosaari
2014-12-06 21:34 ` [PATCH 13/22] si2168: change firmware variable name and type Antti Palosaari
2014-12-06 21:34 ` [PATCH 14/22] si2157: rename device state variable from 's' to 'dev' Antti Palosaari
2014-12-06 21:34 ` [PATCH 15/22] si2157: simplify si2157_cmd_execute() error path Antti Palosaari
2014-12-06 21:34 ` [PATCH 16/22] si2157: carry pointer to client instead of state in tuner_priv Antti Palosaari
2014-12-06 21:34 ` [PATCH 17/22] si2157: change firmware download error handling Antti Palosaari
2014-12-06 21:34 ` [PATCH 18/22] si2157: trivial ID table changes Antti Palosaari
2014-12-06 21:34 ` [PATCH 19/22] si2157: add own goto label for kfree() on probe error Antti Palosaari
2014-12-06 21:34 ` [PATCH 20/22] si2157: print firmware version Antti Palosaari
2014-12-06 21:34 ` [PATCH 21/22] si2157: print chip version Antti Palosaari
2014-12-06 21:34 ` [PATCH 22/22] si2157: change firmware variable name and type Antti Palosaari
2015-01-19 13:24 ` [PATCH 01/22] si2168: define symbol rate limits Hans Verkuil
2015-01-19 13:27 ` Hans Verkuil
2015-01-19 13:30 ` Antti Palosaari
2015-01-19 13:37 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BD0890.8040606@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox