linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Luca Bonissi <lucabon@scarsita.it>,
	Linux Media <linux-media@vger.kernel.org>
Subject: Re: [PATCH] media: gspca_vc032x - wrong bytesperline
Date: Wed, 28 Jan 2015 09:11:55 +0100	[thread overview]
Message-ID: <54C899CB.4050705@redhat.com> (raw)
In-Reply-To: <54C61919.7050508@scarsita.it>

Hi,

On 26-01-15 11:38, Luca Bonissi wrote:
> Hi!
>
> I found a problem on vc032x gspca usb webcam subdriver: "bytesperline" property is wrong for YUYV and YVYU formats.
> With recent v4l-utils library (>=0.9.1), that uses "bytesperline" for pixel format conversion, the result is a wrong jerky image.
>
> Patch tested on my laptop (USB webcam Logitech Orbicam 046d:0892).

Thanks, I've added this patch to my gspca tree, and send a pull-req to
Mauro to get it added to 3.20 .

Regards,

Hans

>
> --- drivers/media/usb/gspca/vc032x.c.orig       2014-08-04 00:25:02.000000000 +0200
> +++ drivers/media/usb/gspca/vc032x.c    2015-01-12 00:28:39.423311693 +0100
> @@ -68,12 +68,12 @@
>
>   static const struct v4l2_pix_format vc0321_mode[] = {
>          {320, 240, V4L2_PIX_FMT_YVYU, V4L2_FIELD_NONE,
> -               .bytesperline = 320,
> +               .bytesperline = 320 * 2,
>                  .sizeimage = 320 * 240 * 2,
>                  .colorspace = V4L2_COLORSPACE_SRGB,
>                  .priv = 1},
>          {640, 480, V4L2_PIX_FMT_YVYU, V4L2_FIELD_NONE,
> -               .bytesperline = 640,
> +               .bytesperline = 640 * 2,
>                  .sizeimage = 640 * 480 * 2,
>                  .colorspace = V4L2_COLORSPACE_SRGB,
>                  .priv = 0},
> @@ -97,12 +97,12 @@
>   };
>   static const struct v4l2_pix_format bi_mode[] = {
>          {320, 240, V4L2_PIX_FMT_YUYV, V4L2_FIELD_NONE,
> -               .bytesperline = 320,
> +               .bytesperline = 320 * 2,
>                  .sizeimage = 320 * 240 * 2,
>                  .colorspace = V4L2_COLORSPACE_SRGB,
>                  .priv = 2},
>          {640, 480, V4L2_PIX_FMT_YUYV, V4L2_FIELD_NONE,
> -               .bytesperline = 640,
> +               .bytesperline = 640 * 2,
>                  .sizeimage = 640 * 480 * 2,
>                  .colorspace = V4L2_COLORSPACE_SRGB,
>                  .priv = 1},
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2015-01-28 20:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 10:38 [PATCH] media: gspca_vc032x - wrong bytesperline Luca Bonissi
2015-01-27 23:37 ` Luca Bonissi
2015-01-28  8:11 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C899CB.4050705@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-media@vger.kernel.org \
    --cc=lucabon@scarsita.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).