From: Hans Verkuil <hverkuil@xs4all.nl>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
linux-media@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats
Date: Mon, 02 Feb 2015 16:08:13 +0100 [thread overview]
Message-ID: <54CF92DD.6020308@xs4all.nl> (raw)
In-Reply-To: <1417614811-15634-1-git-send-email-p.zabel@pengutronix.de>
On 12/03/2014 02:53 PM, Philipp Zabel wrote:
> This patch adds two more 24-bit RGB formats. BGR888 is more or less common,
> GBR888 is used on the internal connection between the IPU display interface
> and the TVE (VGA DAC) on i.MX53 SoCs.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This three-part patch series doesn't apply. Is it on top of another patch
series?
Anyway, it can't be merged unless it is actually used in a driver.
I'm changing this to 'Changes Requested' in patchwork.
Regards,
Hans
> ---
> Changes since v1:
> - Reordered 24-bit RGB formats alphabetically
> ---
> Documentation/DocBook/media/v4l/subdev-formats.xml | 60 ++++++++++++++++++++++
> include/uapi/linux/media-bus-format.h | 4 +-
> 2 files changed, 63 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml
> index 52d7f04..a8da9d3 100644
> --- a/Documentation/DocBook/media/v4l/subdev-formats.xml
> +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
> @@ -469,6 +469,66 @@
> <entry>b<subscript>1</subscript></entry>
> <entry>b<subscript>0</subscript></entry>
> </row>
> + <row id="MEDIA-BUS-FMT-BGR888-1X24">
> + <entry>MEDIA_BUS_FMT_BGR888_1X24</entry>
> + <entry>0x1013</entry>
> + <entry></entry>
> + &dash-ent-8;
> + <entry>b<subscript>7</subscript></entry>
> + <entry>b<subscript>6</subscript></entry>
> + <entry>b<subscript>5</subscript></entry>
> + <entry>b<subscript>4</subscript></entry>
> + <entry>b<subscript>3</subscript></entry>
> + <entry>b<subscript>2</subscript></entry>
> + <entry>b<subscript>1</subscript></entry>
> + <entry>b<subscript>0</subscript></entry>
> + <entry>g<subscript>7</subscript></entry>
> + <entry>g<subscript>6</subscript></entry>
> + <entry>g<subscript>5</subscript></entry>
> + <entry>g<subscript>4</subscript></entry>
> + <entry>g<subscript>3</subscript></entry>
> + <entry>g<subscript>2</subscript></entry>
> + <entry>g<subscript>1</subscript></entry>
> + <entry>g<subscript>0</subscript></entry>
> + <entry>r<subscript>7</subscript></entry>
> + <entry>r<subscript>6</subscript></entry>
> + <entry>r<subscript>5</subscript></entry>
> + <entry>r<subscript>4</subscript></entry>
> + <entry>r<subscript>3</subscript></entry>
> + <entry>r<subscript>2</subscript></entry>
> + <entry>r<subscript>1</subscript></entry>
> + <entry>r<subscript>0</subscript></entry>
> + </row>
> + <row id="MEDIA-BUS-FMT-GBR888-1X24">
> + <entry>MEDIA_BUS_FMT_GBR888_1X24</entry>
> + <entry>0x1014</entry>
> + <entry></entry>
> + &dash-ent-8;
> + <entry>g<subscript>7</subscript></entry>
> + <entry>g<subscript>6</subscript></entry>
> + <entry>g<subscript>5</subscript></entry>
> + <entry>g<subscript>4</subscript></entry>
> + <entry>g<subscript>3</subscript></entry>
> + <entry>g<subscript>2</subscript></entry>
> + <entry>g<subscript>1</subscript></entry>
> + <entry>g<subscript>0</subscript></entry>
> + <entry>b<subscript>7</subscript></entry>
> + <entry>b<subscript>6</subscript></entry>
> + <entry>b<subscript>5</subscript></entry>
> + <entry>b<subscript>4</subscript></entry>
> + <entry>b<subscript>3</subscript></entry>
> + <entry>b<subscript>2</subscript></entry>
> + <entry>b<subscript>1</subscript></entry>
> + <entry>b<subscript>0</subscript></entry>
> + <entry>r<subscript>7</subscript></entry>
> + <entry>r<subscript>6</subscript></entry>
> + <entry>r<subscript>5</subscript></entry>
> + <entry>r<subscript>4</subscript></entry>
> + <entry>r<subscript>3</subscript></entry>
> + <entry>r<subscript>2</subscript></entry>
> + <entry>r<subscript>1</subscript></entry>
> + <entry>r<subscript>0</subscript></entry>
> + </row>
> <row id="MEDIA-BUS-FMT-RGB888-1X24">
> <entry>MEDIA_BUS_FMT_RGB888_1X24</entry>
> <entry>0x100a</entry>
> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
> index 7f8b1e2..10b40dd 100644
> --- a/include/uapi/linux/media-bus-format.h
> +++ b/include/uapi/linux/media-bus-format.h
> @@ -33,7 +33,7 @@
>
> #define MEDIA_BUS_FMT_FIXED 0x0001
>
> -/* RGB - next is 0x1013 */
> +/* RGB - next is 0x1015 */
> #define MEDIA_BUS_FMT_RGB444_1X12 0x100e
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
> @@ -46,6 +46,8 @@
> #define MEDIA_BUS_FMT_RGB565_2X8_LE 0x1008
> #define MEDIA_BUS_FMT_RGB666_1X18 0x1009
> #define MEDIA_BUS_FMT_RGB666_LVDS_SPWG 0x1010
> +#define MEDIA_BUS_FMT_BGR888_1X24 0x1013
> +#define MEDIA_BUS_FMT_GBR888_1X24 0x1014
> #define MEDIA_BUS_FMT_RGB888_1X24 0x100a
> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b
> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c
>
next prev parent reply other threads:[~2015-02-02 15:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 13:53 [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats Philipp Zabel
2014-12-03 13:53 ` [PATCH v2 2/3] Add YUV8_1X24 media bus format Philipp Zabel
2014-12-03 13:53 ` [PATCH 3/3] Add RGB666_1X24_CPADHI " Philipp Zabel
2015-02-02 15:08 ` Hans Verkuil [this message]
2015-02-02 15:21 ` [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats Philipp Zabel
2015-02-02 15:24 ` Mauro Carvalho Chehab
2015-02-02 15:34 ` Philipp Zabel
2015-02-02 15:48 ` Boris Brezillon
2015-02-02 16:51 ` Philipp Zabel
2015-02-04 14:43 ` Sakari Ailus
2015-03-24 9:40 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CF92DD.6020308@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=boris.brezillon@free-electrons.com \
--cc=hans.verkuil@cisco.com \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox