From: Antti Palosaari <crope@iki.fi>
To: Luis de Bethencourt <luis@debethencourt.com>,
linux-media@vger.kernel.org
Cc: mchehab@osg.samsung.com, crop@iki.fi, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] rtl2832: remove compiler warning
Date: Wed, 11 Feb 2015 15:07:05 +0200 [thread overview]
Message-ID: <54DB53F9.9070704@iki.fi> (raw)
In-Reply-To: <20150211110851.GA30505@biggie>
On 02/11/2015 01:08 PM, Luis de Bethencourt wrote:
> Cleaning up the following compiler warning:
> rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
>
> Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
> tmp, this line would never run because we go to err. It is still nice to avoid
> compiler warnings.
>
> Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
Reviewed-by: Antti Palosaari <crope@iki.fi>
Antti
> ---
> drivers/media/dvb-frontends/rtl2832.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
> index 5d2d8f4..20fa245 100644
> --- a/drivers/media/dvb-frontends/rtl2832.c
> +++ b/drivers/media/dvb-frontends/rtl2832.c
> @@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
> struct rtl2832_dev *dev = fe->demodulator_priv;
> struct i2c_client *client = dev->client;
> int ret;
> - u32 tmp;
> + u32 uninitialized_var(tmp);
>
> dev_dbg(&client->dev, "\n");
>
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2015-02-11 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 11:08 [PATCH v2] rtl2832: remove compiler warning Luis de Bethencourt
2015-02-11 13:07 ` Antti Palosaari [this message]
2015-02-15 22:46 ` Luis de Bethencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB53F9.9070704@iki.fi \
--to=crope@iki.fi \
--cc=crop@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luis@debethencourt.com \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).