* [PATCH] media: docs: Correct NV{12,21}/M pixel formats, chroma samples used.
@ 2015-02-11 19:32 Miguel Casas-Sanchez
2015-02-16 12:22 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Miguel Casas-Sanchez @ 2015-02-11 19:32 UTC (permalink / raw)
To: linux-media, hverkuil
Docos says for these pixel formats:
start... : Cb00 Cr00 Cb01 Cr01
start... : Cb10 Cr10 Cb11 Cr11
whereas it should read:
start... : Cb00 Cr00 Cb11 Cr11
start... : Cb20 Cr20 Cb21 Cr21
where ... depends on the exact multi/single planar format.
See e.g. http://linuxtv.org/downloads/v4l-dvb-apis/re30.html
and http://linuxtv.org/downloads/v4l-dvb-apis/re31.html
Signed-off-by: Miguel Casas-Sanchez <mcasas@chromium.org>
---
Documentation/DocBook/media/v4l/pixfmt-nv12.xml | 8 ++++----
Documentation/DocBook/media/v4l/pixfmt-nv12m.xml | 12 ++++++------
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/Documentation/DocBook/media/v4l/pixfmt-nv12.xml
b/Documentation/DocBook/media/v4l/pixfmt-nv12.xml
index 84dd4fd..4148696 100644
--- a/Documentation/DocBook/media/v4l/pixfmt-nv12.xml
+++ b/Documentation/DocBook/media/v4l/pixfmt-nv12.xml
@@ -73,15 +73,15 @@ pixel image</title>
<entry>start + 16:</entry>
<entry>Cb<subscript>00</subscript></entry>
<entry>Cr<subscript>00</subscript></entry>
- <entry>Cb<subscript>01</subscript></entry>
- <entry>Cr<subscript>01</subscript></entry>
+ <entry>Cb<subscript>02</subscript></entry>
+ <entry>Cr<subscript>02</subscript></entry>
</row>
<row>
<entry>start + 20:</entry>
<entry>Cb<subscript>10</subscript></entry>
<entry>Cr<subscript>10</subscript></entry>
- <entry>Cb<subscript>11</subscript></entry>
- <entry>Cr<subscript>11</subscript></entry>
+ <entry>Cb<subscript>22</subscript></entry>
+ <entry>Cr<subscript>22</subscript></entry>
</row>
</tbody>
</tgroup>
diff --git a/Documentation/DocBook/media/v4l/pixfmt-nv12m.xml
b/Documentation/DocBook/media/v4l/pixfmt-nv12m.xml
index f3a3d45..e0a35ea 100644
--- a/Documentation/DocBook/media/v4l/pixfmt-nv12m.xml
+++ b/Documentation/DocBook/media/v4l/pixfmt-nv12m.xml
@@ -83,15 +83,15 @@ CbCr plane has as many pad bytes after its rows.</para>
<entry>start1 + 0:</entry>
<entry>Cb<subscript>00</subscript></entry>
<entry>Cr<subscript>00</subscript></entry>
- <entry>Cb<subscript>01</subscript></entry>
- <entry>Cr<subscript>01</subscript></entry>
+ <entry>Cb<subscript>02</subscript></entry>
+ <entry>Cr<subscript>02</subscript></entry>
</row>
<row>
<entry>start1 + 4:</entry>
- <entry>Cb<subscript>10</subscript></entry>
- <entry>Cr<subscript>10</subscript></entry>
- <entry>Cb<subscript>11</subscript></entry>
- <entry>Cr<subscript>11</subscript></entry>
+ <entry>Cb<subscript>20</subscript></entry>
+ <entry>Cr<subscript>20</subscript></entry>
+ <entry>Cb<subscript>22</subscript></entry>
+ <entry>Cr<subscript>22</subscript></entry>
</row>
</tbody>
</tgroup>
--
2.2.0.rc0.207.ga3a616c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: docs: Correct NV{12,21}/M pixel formats, chroma samples used.
2015-02-11 19:32 [PATCH] media: docs: Correct NV{12,21}/M pixel formats, chroma samples used Miguel Casas-Sanchez
@ 2015-02-16 12:22 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2015-02-16 12:22 UTC (permalink / raw)
To: Miguel Casas-Sanchez, linux-media
On 02/11/2015 08:32 PM, Miguel Casas-Sanchez wrote:
> Docos says for these pixel formats:
>
> start... : Cb00 Cr00 Cb01 Cr01
> start... : Cb10 Cr10 Cb11 Cr11
>
> whereas it should read:
>
> start... : Cb00 Cr00 Cb11 Cr11
> start... : Cb20 Cr20 Cb21 Cr21
>
> where ... depends on the exact multi/single planar format.
>
> See e.g. http://linuxtv.org/downloads/v4l-dvb-apis/re30.html
> and http://linuxtv.org/downloads/v4l-dvb-apis/re31.html
>
>
> Signed-off-by: Miguel Casas-Sanchez <mcasas@chromium.org>
Nacked-by: Hans Verkuil <hans.verkuil@cisco.com>
The Chroma coordinates are those of the CbCr plane, not the luma
plane. This is true for all other YCbCr format descriptions as well.
Regards,
Hans
> ---
> Documentation/DocBook/media/v4l/pixfmt-nv12.xml | 8 ++++----
> Documentation/DocBook/media/v4l/pixfmt-nv12m.xml | 12 ++++++------
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/DocBook/media/v4l/pixfmt-nv12.xml
> b/Documentation/DocBook/media/v4l/pixfmt-nv12.xml
> index 84dd4fd..4148696 100644
> --- a/Documentation/DocBook/media/v4l/pixfmt-nv12.xml
> +++ b/Documentation/DocBook/media/v4l/pixfmt-nv12.xml
> @@ -73,15 +73,15 @@ pixel image</title>
> <entry>start + 16:</entry>
> <entry>Cb<subscript>00</subscript></entry>
> <entry>Cr<subscript>00</subscript></entry>
> - <entry>Cb<subscript>01</subscript></entry>
> - <entry>Cr<subscript>01</subscript></entry>
> + <entry>Cb<subscript>02</subscript></entry>
> + <entry>Cr<subscript>02</subscript></entry>
> </row>
> <row>
> <entry>start + 20:</entry>
> <entry>Cb<subscript>10</subscript></entry>
> <entry>Cr<subscript>10</subscript></entry>
> - <entry>Cb<subscript>11</subscript></entry>
> - <entry>Cr<subscript>11</subscript></entry>
> + <entry>Cb<subscript>22</subscript></entry>
> + <entry>Cr<subscript>22</subscript></entry>
> </row>
> </tbody>
> </tgroup>
> diff --git a/Documentation/DocBook/media/v4l/pixfmt-nv12m.xml
> b/Documentation/DocBook/media/v4l/pixfmt-nv12m.xml
> index f3a3d45..e0a35ea 100644
> --- a/Documentation/DocBook/media/v4l/pixfmt-nv12m.xml
> +++ b/Documentation/DocBook/media/v4l/pixfmt-nv12m.xml
> @@ -83,15 +83,15 @@ CbCr plane has as many pad bytes after its rows.</para>
> <entry>start1 + 0:</entry>
> <entry>Cb<subscript>00</subscript></entry>
> <entry>Cr<subscript>00</subscript></entry>
> - <entry>Cb<subscript>01</subscript></entry>
> - <entry>Cr<subscript>01</subscript></entry>
> + <entry>Cb<subscript>02</subscript></entry>
> + <entry>Cr<subscript>02</subscript></entry>
> </row>
> <row>
> <entry>start1 + 4:</entry>
> - <entry>Cb<subscript>10</subscript></entry>
> - <entry>Cr<subscript>10</subscript></entry>
> - <entry>Cb<subscript>11</subscript></entry>
> - <entry>Cr<subscript>11</subscript></entry>
> + <entry>Cb<subscript>20</subscript></entry>
> + <entry>Cr<subscript>20</subscript></entry>
> + <entry>Cb<subscript>22</subscript></entry>
> + <entry>Cr<subscript>22</subscript></entry>
> </row>
> </tbody>
> </tgroup>
>
> --
> 2.2.0.rc0.207.ga3a616c
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-16 12:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-11 19:32 [PATCH] media: docs: Correct NV{12,21}/M pixel formats, chroma samples used Miguel Casas-Sanchez
2015-02-16 12:22 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).