From: Antti Palosaari <crope@iki.fi>
To: Devin Heitmueller <dheitmueller@kernellabs.com>,
Shuah Khan <shuahkh@osg.samsung.com>
Cc: "mauro Carvalho Chehab (m.chehab@samsung.com)"
<m.chehab@samsung.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] xc5000: fix memory corruption when unplugging device
Date: Wed, 25 Feb 2015 20:13:49 +0200 [thread overview]
Message-ID: <54EE10DD.9020205@iki.fi> (raw)
In-Reply-To: <CAGoCfiyN_iQ6vGn0YGUD_OxngwKEMs056Gzp4yW9wWjSa8Lisw@mail.gmail.com>
On 02/25/2015 07:56 PM, Devin Heitmueller wrote:
>> I would request you to add a comment here indicating the
>> hybrid case scenario to avoid any future cleanup type work
>> deciding there is no need to set priv->firmware to null
>> since priv gets released in hybrid_tuner_release_state(priv);
>
> No, I'm not going to rebase my tree and regenerate the patch just to
> add a comment explaining how hybrid_tuner_[request/release]_state()
> works (which, btw, is how it works in all hybrid tuner drivers). I
> already wasted enough of my time tracking down the source of the
> memory corruption and providing a fix for this regression. If you
> want to submit a subsequent patch with a comment, be my guest.
These are just the issues I would like to implement drivers as standard
I2C driver model =) Attaching driver for one chip twice is ugly hack!
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2015-02-25 18:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 17:29 [PATCH] xc5000: fix memory corruption when unplugging device Devin Heitmueller
2015-02-25 14:08 ` Shuah Khan
2015-02-25 17:56 ` Devin Heitmueller
2015-02-25 18:13 ` Antti Palosaari [this message]
2015-02-25 18:37 ` Devin Heitmueller
2015-02-25 19:02 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EE10DD.9020205@iki.fi \
--to=crope@iki.fi \
--cc=dheitmueller@kernellabs.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).