From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb2-smtp-cloud3.xs4all.net ([194.109.24.26]:53488 "EHLO lb2-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678AbbCCJja (ORCPT ); Tue, 3 Mar 2015 04:39:30 -0500 Message-ID: <54F58142.4030201@xs4all.nl> Date: Tue, 03 Mar 2015 10:39:14 +0100 From: Hans Verkuil MIME-Version: 1.0 To: "Lad, Prabhakar" CC: Scott Jiang , adi-buildroot-devel@lists.sourceforge.net, Mauro Carvalho Chehab , LMML , LKML Subject: Re: [PATCH v3 00/15] media: blackfin: bfin_capture enhancements References: <1424544001-19045-1-git-send-email-prabhakar.csengg@gmail.com> <54F575AD.5020307@xs4all.nl> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 03/03/2015 10:30 AM, Lad, Prabhakar wrote: > Hi Hans, > > On Tue, Mar 3, 2015 at 8:49 AM, Hans Verkuil wrote: >> On 03/02/2015 08:57 AM, Scott Jiang wrote: >>> Hi Lad and Hans, >>> >>> 2015-02-22 2:39 GMT+08:00 Lad Prabhakar : >>>> From: "Lad, Prabhakar" >>>> >>>> This patch series, enhances blackfin capture driver with >>>> vb2 helpers. >>>> >>>> Changes for v3: >>>> 1: patches unchanged except for patch 8/15 fixing starting of ppi only >>>> after we have the resources. >>>> 2: Rebased on media tree. >>>> >>>> v2: http://lkml.iu.edu/hypermail/linux/kernel/1501.2/04655.html >>>> >>>> v1: https://lkml.org/lkml/2014/12/20/27 >>>> >>>> Lad, Prabhakar (15): >>>> media: blackfin: bfin_capture: drop buf_init() callback >>>> media: blackfin: bfin_capture: release buffers in case >>>> start_streaming() call back fails >>>> media: blackfin: bfin_capture: set min_buffers_needed >>>> media: blackfin: bfin_capture: improve buf_prepare() callback >>>> media: blackfin: bfin_capture: improve queue_setup() callback >>>> media: blackfin: bfin_capture: use vb2_fop_mmap/poll >>>> media: blackfin: bfin_capture: use v4l2_fh_open and vb2_fop_release >>>> media: blackfin: bfin_capture: use vb2_ioctl_* helpers >>>> media: blackfin: bfin_capture: make sure all buffers are returned on >>>> stop_streaming() callback >>>> media: blackfin: bfin_capture: return -ENODATA for *std calls >>>> media: blackfin: bfin_capture: return -ENODATA for *dv_timings calls >>>> media: blackfin: bfin_capture: add support for vidioc_create_bufs >>>> media: blackfin: bfin_capture: add support for VB2_DMABUF >>>> media: blackfin: bfin_capture: add support for VIDIOC_EXPBUF >>>> media: blackfin: bfin_capture: set v4l2 buffer sequence >>>> >>>> drivers/media/platform/blackfin/bfin_capture.c | 306 ++++++++----------------- >>>> 1 file changed, 94 insertions(+), 212 deletions(-) >>>> >>>> -- >>> >>> For all these patches, >>> Acked-by: Scott Jiang >>> Tested-by: Scott Jiang >> >> Thanks! >> >> Is it possible for you to run 'v4l2-compliance -s' with this driver and >> report the results? I'd be interested in that. >> > Fyi.. > v4l2-utils can't be compiled under uClibc. Do you know what exactly fails? Is it possible to manually compile v4l2-compliance? I.e., try this: cd utils/v4l2-compliance cat *.cpp >x.cpp g++ -o v4l2-compliance x.cpp -I . -I ../../include/ -DNO_LIBV4L2 I've never used uclibc, so I don't know what the limitations are. Regards, Hans