From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: linux-media@vger.kernel.org, mchehab@osg.samsung.com,
hans.verkuil@cisco.com
Subject: em38xx locking question
Date: Tue, 10 Mar 2015 10:18:48 -0300 [thread overview]
Message-ID: <54FEEF38.6060506@vanguardiasur.com.ar> (raw)
Mauro,
Function drivers/media/usb/em28xx/em28xx-video.c:get_next_buf
(copy pasted below for reference) does not take the list spinlock,
yet it modifies the list. Is that correct?
static inline struct em28xx_buffer *get_next_buf(struct em28xx *dev,
struct em28xx_dmaqueue *dma_q)
{
struct em28xx_buffer *buf;
if (list_empty(&dma_q->active)) {
em28xx_isocdbg("No active queue to serve\n");
return NULL;
}
/* Get the next buffer */
buf = list_entry(dma_q->active.next, struct em28xx_buffer, list);
/* Cleans up buffer - Useful for testing for frame/URB loss */
list_del(&buf->list);
buf->pos = 0;
buf->vb_buf = buf->mem;
return buf;
}
Thanks!
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
next reply other threads:[~2015-03-10 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 13:18 Ezequiel Garcia [this message]
2015-03-10 13:26 ` em38xx locking question Hans Verkuil
2015-03-10 13:29 ` Ezequiel Garcia
2015-03-10 13:46 ` Hans Verkuil
2015-03-10 14:06 ` Ezequiel Garcia
2015-03-10 14:16 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FEEF38.6060506@vanguardiasur.com.ar \
--to=ezequiel@vanguardiasur.com.ar \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox