From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:51446 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932138AbbDGXJk (ORCPT ); Tue, 7 Apr 2015 19:09:40 -0400 Message-ID: <552463B3.4040804@codeaurora.org> Date: Tue, 07 Apr 2015 16:09:39 -0700 From: Stephen Boyd MIME-Version: 1.0 To: Russell King - ARM Linux CC: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH 06/14] clkdev: add clkdev_create() helper References: <20150403171149.GC13898@n2100.arm.linux.org.uk> <5522EA55.5080804@codeaurora.org> <20150407124342.GJ4027@n2100.arm.linux.org.uk> In-Reply-To: <20150407124342.GJ4027@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 04/07/15 05:43, Russell King - ARM Linux wrote: > On Mon, Apr 06, 2015 at 01:19:33PM -0700, Stephen Boyd wrote: >> On 04/03/15 10:12, Russell King wrote: >>> @@ -316,6 +329,29 @@ clkdev_alloc(struct clk *clk, const char *con_id, const char *dev_fmt, ...) >>> } >>> EXPORT_SYMBOL(clkdev_alloc); >>> >>> +/** >>> + * clkdev_create - allocate and add a clkdev lookup structure >>> + * @clk: struct clk to associate with all clk_lookups >>> + * @con_id: connection ID string on device >>> + * @dev_fmt: format string describing device name >>> + * >>> + * Returns a clk_lookup structure, which can be later unregistered and >>> + * freed. >> Please add that this returns NULL on failure. > Will do, but please remember that _I'm_ taking the clkdev patches through > my tree, as I'm the maintainer for clkdev. Thanks. > Sounds good to me. Thanks. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project