From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.kundenserver.de ([212.227.126.187]:65440 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754212AbbKQQab (ORCPT ); Tue, 17 Nov 2015 11:30:31 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab , Antti Palosaari , linux-kernel@vger.kernel.org Subject: Re: [PATCH] [MEDIA] dvb: usb: fix dib3000mc dependencies Date: Tue, 17 Nov 2015 17:24:23 +0100 Message-ID: <5525192.eyIcy1NRHy@wuerfel> In-Reply-To: <3984729.n55BH9Zr8c@wuerfel> References: <3984729.n55BH9Zr8c@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: On Tuesday 17 November 2015 17:17:39 Arnd Bergmann wrote: > The dibusb_read_eeprom_byte function is defined in dibusb-common.c, > but that file is not compiled for CONFIG_DVB_USB_DIBUSB_MB as it > is for the other driver using the common functions, so we can > get a link error: > > drivers/built-in.o: In function `dibusb_dib3000mc_tuner_attach': > (.text+0x2c5124): undefined reference to `dibusb_read_eeprom_byte' > (.text+0x2c5134): undefined reference to `dibusb_read_eeprom_byte' > > This changes the Makefile to treat the file like all the others > in this directory, and enforce building dvb-usb-dibusb-common.o > as a dependency. > > Signed-off-by: Arnd Bergmann > I just realized that this depends on another patch I've sent back in April, so that is probably no longer in the patch queue. Please disregard for now. Arnd