Re: linux-next: Tree for Apr 10 (media/i2c/ov2659)

Re: linux-next: Tree for Apr 10 (media/i2c/ov2659)

[Randy Dunlap]

On 04/10/15 04:18, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20150409:
> 

on x86_64:
when # CONFIG_VIDEO_V4L2_SUBDEV_API is not set:


  CC [M]  drivers/media/i2c/ov2659.o
../drivers/media/i2c/ov2659.c: In function 'ov2659_get_fmt':
../drivers/media/i2c/ov2659.c:1054:3: error: implicit declaration of function 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration]
   mf = v4l2_subdev_get_try_format(sd, cfg, 0);
   ^
../drivers/media/i2c/ov2659.c:1054:6: warning: assignment makes pointer from integer without a cast [enabled by default]
   mf = v4l2_subdev_get_try_format(sd, cfg, 0);
      ^
../drivers/media/i2c/ov2659.c: In function 'ov2659_set_fmt':
../drivers/media/i2c/ov2659.c:1129:6: warning: assignment makes pointer from integer without a cast [enabled by default]
   mf = v4l2_subdev_get_try_format(sd, cfg, fmt->pad);
      ^
../drivers/media/i2c/ov2659.c: In function 'ov2659_open':
../drivers/media/i2c/ov2659.c:1264:38: error: 'struct v4l2_subdev_fh' has no member named 'pad'
     v4l2_subdev_get_try_format(sd, fh->pad, 0);
                                      ^



-- 
~Randy

Re: linux-next: Tree for Apr 10 (media/i2c/adp1653)

[Randy Dunlap]

On 04/10/15 04:18, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20150409:
> 

on i386:

  CC [M]  drivers/media/i2c/adp1653.o
../drivers/media/i2c/adp1653.c: In function '__adp1653_set_power':
../drivers/media/i2c/adp1653.c:317:38: error: 'struct adp1653_platform_data' has no member named 'power_gpio'
   gpio_set_value(flash->platform_data->power_gpio, on);
                                      ^
../drivers/media/i2c/adp1653.c:336:38: error: 'struct adp1653_platform_data' has no member named 'power_gpio'
   gpio_set_value(flash->platform_data->power_gpio, 0);
                                      ^
../drivers/media/i2c/adp1653.c: In function 'adp1653_of_init':
../drivers/media/i2c/adp1653.c:471:4: error: 'struct adp1653_platform_data' has no member named 'power_gpio'
  pd->power_gpio = of_get_gpio_flags(node, 0, &flags);
    ^
../drivers/media/i2c/adp1653.c:472:8: error: 'struct adp1653_platform_data' has no member named 'power_gpio'
  if (pd->power_gpio < 0) {
        ^
../drivers/media/i2c/adp1653.c:433:6: warning: unused variable 'gpio' [-Wunused-variable]
  int gpio;
      ^



-- 
~Randy

Re: linux-next: Tree for Apr 10 (media/i2c/adp1653)

[Randy Dunlap]

[change email address for maintainer]

On 04/10/15 10:23, Randy Dunlap wrote:
> On 04/10/15 04:18, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20150409:
>>
> 
> on i386:
> 
>   CC [M]  drivers/media/i2c/adp1653.o
> ../drivers/media/i2c/adp1653.c: In function '__adp1653_set_power':
> ../drivers/media/i2c/adp1653.c:317:38: error: 'struct adp1653_platform_data' has no member named 'power_gpio'
>    gpio_set_value(flash->platform_data->power_gpio, on);
>                                       ^
> ../drivers/media/i2c/adp1653.c:336:38: error: 'struct adp1653_platform_data' has no member named 'power_gpio'
>    gpio_set_value(flash->platform_data->power_gpio, 0);
>                                       ^
> ../drivers/media/i2c/adp1653.c: In function 'adp1653_of_init':
> ../drivers/media/i2c/adp1653.c:471:4: error: 'struct adp1653_platform_data' has no member named 'power_gpio'
>   pd->power_gpio = of_get_gpio_flags(node, 0, &flags);
>     ^
> ../drivers/media/i2c/adp1653.c:472:8: error: 'struct adp1653_platform_data' has no member named 'power_gpio'
>   if (pd->power_gpio < 0) {
>         ^
> ../drivers/media/i2c/adp1653.c:433:6: warning: unused variable 'gpio' [-Wunused-variable]
>   int gpio;
>       ^
> 
> 
> 


-- 
~Randy

Re: linux-next: Tree for Apr 10 (media/i2c/adp1653)

[Sakari Ailus]

Hi Randy and others,

On Fri, Apr 10, 2015 at 10:25:23AM -0700, Randy Dunlap wrote:
...
> > ../drivers/media/i2c/adp1653.c:433:6: warning: unused variable 'gpio' [-Wunused-variable]
> >   int gpio;

A preliminary patch for adp1653 DT support was accidentally merged to
media-tree. It's now reverted in media-tree:

---
commit be8e58d93fba531b12ef2fce4fb33c9c5fb5b69f
Author: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Date:   Thu Apr 9 07:33:45 2015 -0300

    Revert "[media] Add device tree support to adp1653 flash driver"
    
    As requested by Sakari:
    
        "The driver changes are still being reviewed.
         It's been proposed that the max-microamp property be renamed."
    
    So, as the DT bindings are not agreed upstream yet, let's revert
    it.
    
    Requested-by: Sakari Ailus <sakari.ailus@iki.fi>
    This reverts commit b6100f10bdc2019a65297d2597c388de2f7dd653.
---

I thus believe the problem in linux-next should disappear by itself. In the
meantime, the revert from media-tree could be used if needed.

Thanks.

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk