public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: "Tycho Lürsen" <tycholursen@gmail.com>
To: Olli Salonen <olli.salonen@iki.fi>, linux-media@vger.kernel.org
Subject: Re: [PATCH 02/12] dvbsky: use si2168 config option ts_clock_gapped
Date: Fri, 24 Apr 2015 08:31:55 +0200	[thread overview]
Message-ID: <5539E35B.2080603@gmail.com> (raw)
In-Reply-To: <1429823471-21835-2-git-send-email-olli.salonen@iki.fi>

Hi Olli,
in saa716x_budget.c I've also got (for TBS6285)

     si2168_config.i2c_adapter = &i2cadapter;
     si2168_config.fe = &adapter->fe;
     si2168_config.ts_mode = SI2168_TS_SERIAL;
     memset(&info, 0, sizeof(struct i2c_board_info));

Should I just add it like this?

     si2168_config.ts_mode = SI2168_TS_SERIAL;
     si2168_config.ts_clock_gapped = true;
     memset(&info, 0, sizeof(struct i2c_board_info));

Kind regards,
Tycho.

Op 23-04-15 om 23:11 schreef Olli Salonen:
> Change the dvbsky driver to support gapped clock instead of the current
> hack.
>
> Signed-off-by: Olli Salonen <olli.salonen@iki.fi>
> ---
>   drivers/media/usb/dvb-usb-v2/dvbsky.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c
> index cdf59bc..0f73b1d 100644
> --- a/drivers/media/usb/dvb-usb-v2/dvbsky.c
> +++ b/drivers/media/usb/dvb-usb-v2/dvbsky.c
> @@ -615,7 +615,8 @@ static int dvbsky_t330_attach(struct dvb_usb_adapter *adap)
>   	memset(&si2168_config, 0, sizeof(si2168_config));
>   	si2168_config.i2c_adapter = &i2c_adapter;
>   	si2168_config.fe = &adap->fe[0];
> -	si2168_config.ts_mode = SI2168_TS_PARALLEL | 0x40;
> +	si2168_config.ts_mode = SI2168_TS_PARALLEL;
> +	si2168_config.ts_clock_gapped = true;
>   	memset(&info, 0, sizeof(struct i2c_board_info));
>   	strlcpy(info.type, "si2168", I2C_NAME_SIZE);
>   	info.addr = 0x64;


  reply	other threads:[~2015-04-24  6:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 21:11 [PATCH 01/12] si2168: add support for gapped clock Olli Salonen
2015-04-23 21:11 ` [PATCH 02/12] dvbsky: use si2168 config option ts_clock_gapped Olli Salonen
2015-04-24  6:31   ` Tycho Lürsen [this message]
2015-04-24  6:57   ` Tycho Lürsen
     [not found]     ` <CAAZRmGzPZaJoMtHXYuFo081xbG3Eb_1+WwePziKfp6R5kREGDw@mail.gmail.com>
2015-04-24  7:03       ` Olli Salonen
2015-04-24 13:16         ` Steven Toth
2015-04-24 14:01           ` Tycho Lürsen
2015-04-24 14:10             ` Steven Toth
2015-04-27 11:51           ` Olli Salonen
2015-04-23 21:11 ` [PATCH 03/12] si2157: support selection of IF interface Olli Salonen
2015-04-24  3:52   ` Mauro Carvalho Chehab
2015-04-23 21:11 ` [PATCH 04/12] cx23885: specify if_port for si2157 devices Olli Salonen
2015-04-23 21:11 ` [PATCH 05/12] smipcie: " Olli Salonen
2015-04-23 21:11 ` [PATCH 06/12] cx231xx: " Olli Salonen
2015-04-23 21:11 ` [PATCH 07/12] af9035: " Olli Salonen
2015-04-23 21:11 ` [PATCH 08/12] dvbsky: " Olli Salonen
2015-04-23 21:11 ` [PATCH 09/12] cxusb: " Olli Salonen
2015-04-23 21:11 ` [PATCH 10/12] em28xx: " Olli Salonen
2015-04-23 21:11 ` [PATCH 11/12] rtl28xxu: add I2C read without write Olli Salonen
2015-04-23 21:11 ` [PATCH 12/12] rtl2832: add support for GoTView MasterHD 3 USB tuner Olli Salonen
2015-04-23 22:07   ` Benjamin Larsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5539E35B.2080603@gmail.com \
    --to=tycholursen@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=olli.salonen@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox