From: Hans Verkuil <hverkuil@xs4all.nl>
To: TCMaps@gmx.net, linux-media@vger.kernel.org
Subject: Re: [PATCH] fix: make menuconfig breaks due to whitespaces in Kconfig
Date: Fri, 24 Apr 2015 09:38:41 +0200 [thread overview]
Message-ID: <5539F301.4080304@xs4all.nl> (raw)
In-Reply-To: <trinity-ae8b4068-9fe5-4516-ab2f-1e8f7c02436a-1428636115681@msvc021>
Hi,
Can you show the Kconfig script that contains the syntax error? I don't
quite see how this goes wrong. Perhaps if I see the broken Kconfig I
understand this better.
Thanks,
Hans
On 04/10/2015 05:21 AM, TCMaps@gmx.net wrote:
> From: TC <tcmaps@gmx.net>
> Date: Fri, 10 Apr 2015 04:29:20 +0200
> Subject: on some systems like Ubuntu 14.04, whitespaces are added from make_kconfig.pl to Kconfig script during make menuconfig
> causing it to fail with "./Kconfig:778: syntax error"!
> this patch just removes the originating spaces in two lines
>
>
> ---
> v4l/scripts/make_kconfig.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/v4l/scripts/make_kconfig.pl b/v4l/scripts/make_kconfig.pl
> index 28b56d0..9228a7b 100755
> --- a/v4l/scripts/make_kconfig.pl
> +++ b/v4l/scripts/make_kconfig.pl
> @@ -252,8 +252,8 @@ sub checkdeps()
> # Text to be added to disabled options
> my $disabled_msg = <<'EOF';
> ---help---
> - WARNING! This driver needs at least kernel %s! It may not
> - compile or work correctly on your kernel, which is too old.
> + WARNING! This driver needs at least kernel %s! It may not
> + compile or work correctly on your kernel, which is too old.
>
> EOF
>
>
prev parent reply other threads:[~2015-04-24 7:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 3:21 [PATCH] fix: make menuconfig breaks due to whitespaces in Kconfig TCMaps
2015-04-24 7:38 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5539F301.4080304@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=TCMaps@gmx.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox