public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fix: make menuconfig breaks due to whitespaces in Kconfig
@ 2015-04-10  3:21 TCMaps
  2015-04-24  7:38 ` Hans Verkuil
  0 siblings, 1 reply; 2+ messages in thread
From: TCMaps @ 2015-04-10  3:21 UTC (permalink / raw)
  To: linux-media

From: TC <tcmaps@gmx.net>
Date: Fri, 10 Apr 2015 04:29:20 +0200
Subject: on some systems like Ubuntu 14.04, whitespaces are added from make_kconfig.pl to Kconfig script during make menuconfig
causing it to fail with "./Kconfig:778: syntax error"!
this patch just removes the originating spaces in two lines


---
 v4l/scripts/make_kconfig.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/v4l/scripts/make_kconfig.pl b/v4l/scripts/make_kconfig.pl
index 28b56d0..9228a7b 100755
--- a/v4l/scripts/make_kconfig.pl
+++ b/v4l/scripts/make_kconfig.pl
@@ -252,8 +252,8 @@ sub checkdeps()
 # Text to be added to disabled options
 my $disabled_msg = <<'EOF';
 	---help---
-	  WARNING! This driver needs at least kernel %s!  It may not
-	  compile or work correctly on your kernel, which is too old.
+	WARNING! This driver needs at least kernel %s!  It may not
+	compile or work correctly on your kernel, which is too old.
 
 EOF
 
-- 
1.9.5.msysgit.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix: make menuconfig breaks due to whitespaces in Kconfig
  2015-04-10  3:21 [PATCH] fix: make menuconfig breaks due to whitespaces in Kconfig TCMaps
@ 2015-04-24  7:38 ` Hans Verkuil
  0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2015-04-24  7:38 UTC (permalink / raw)
  To: TCMaps, linux-media

Hi,

Can you show the Kconfig script that contains the syntax error? I don't
quite see how this goes wrong. Perhaps if I see the broken Kconfig I
understand this better.

Thanks,

	Hans

On 04/10/2015 05:21 AM, TCMaps@gmx.net wrote:
> From: TC <tcmaps@gmx.net>
> Date: Fri, 10 Apr 2015 04:29:20 +0200
> Subject: on some systems like Ubuntu 14.04, whitespaces are added from make_kconfig.pl to Kconfig script during make menuconfig
> causing it to fail with "./Kconfig:778: syntax error"!
> this patch just removes the originating spaces in two lines
> 
> 
> ---
>  v4l/scripts/make_kconfig.pl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/v4l/scripts/make_kconfig.pl b/v4l/scripts/make_kconfig.pl
> index 28b56d0..9228a7b 100755
> --- a/v4l/scripts/make_kconfig.pl
> +++ b/v4l/scripts/make_kconfig.pl
> @@ -252,8 +252,8 @@ sub checkdeps()
>  # Text to be added to disabled options
>  my $disabled_msg = <<'EOF';
>  	---help---
> -	  WARNING! This driver needs at least kernel %s!  It may not
> -	  compile or work correctly on your kernel, which is too old.
> +	WARNING! This driver needs at least kernel %s!  It may not
> +	compile or work correctly on your kernel, which is too old.
>  
>  EOF
>  
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-24  7:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-10  3:21 [PATCH] fix: make menuconfig breaks due to whitespaces in Kconfig TCMaps
2015-04-24  7:38 ` Hans Verkuil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox