Re: [PATCH 5/9] ov5642: avoid calling ov5642_find_datafmt() twice

Guennadi Liakhovetski
2015-05-03T20:24:15Z

Hi Hans,

On Sun, 3 May 2015, Hans Verkuil wrote:

> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> Simplify ov5642_set_fmt().
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> drivers/media/i2c/soc_camera/ov5642.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/soc_camera/ov5642.c b/drivers/media/i2c/soc_camera/ov5642.c
> index bab9ac0..061fca3 100644
> --- a/drivers/media/i2c/soc_camera/ov5642.c
> +++ b/drivers/media/i2c/soc_camera/ov5642.c
> @@ -804,14 +804,15 @@ static int ov5642_set_fmt(struct v4l2_subdev *sd,
> if (!fmt) {
> if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE)
> return -EINVAL;
> - mf->code = ov5642_colour_fmts[0].code;
> - mf->colorspace = ov5642_colour_fmts[0].colorspace;
> + fmt = ov5642_colour_fmts;
> + mf->code = fmt->code;
> + mf->colorspace = fmt->colorspace;

Again - I still don't see why this is needed.

Thanks
Guennadi

> }
>
> mf->field = V4L2_FIELD_NONE;
>
> if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE)
> - priv->fmt = ov5642_find_datafmt(mf->code);
> + priv->fmt = fmt;
> else
> cfg->try_fmt = *mf;
> return 0;
> --
> 2.1.4
>