* [PATCH] rcar-vin: use monotonic timestamps
@ 2015-05-07 6:26 Hans Verkuil
2015-05-07 6:32 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2015-05-07 6:26 UTC (permalink / raw)
To: Linux Media Mailing List
Cc: Sakari Ailus, Nobuhiro Iwamatsu, Guennadi Liakhovetski,
Vladimir Barinov
Even though the rcar-vin driver tells userspace that it will give a monotonic
timestamp, it is actually using gettimeofday. Replace this with a proper
monotonic timestamp.
diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
index 35deed8..b64dfea 100644
--- a/drivers/media/platform/soc_camera/rcar_vin.c
+++ b/drivers/media/platform/soc_camera/rcar_vin.c
@@ -894,7 +894,7 @@ static irqreturn_t rcar_vin_irq(int irq, void *data)
priv->queue_buf[slot]->v4l2_buf.field = priv->field;
priv->queue_buf[slot]->v4l2_buf.sequence = priv->sequence++;
- do_gettimeofday(&priv->queue_buf[slot]->v4l2_buf.timestamp);
+ v4l2_get_timestamp(&priv->queue_buf[slot]->v4l2_buf.timestamp);
vb2_buffer_done(priv->queue_buf[slot], VB2_BUF_STATE_DONE);
priv->queue_buf[slot] = NULL;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rcar-vin: use monotonic timestamps
2015-05-07 6:26 [PATCH] rcar-vin: use monotonic timestamps Hans Verkuil
@ 2015-05-07 6:32 ` Hans Verkuil
2015-05-11 12:45 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2015-05-07 6:32 UTC (permalink / raw)
To: Linux Media Mailing List
Cc: Sakari Ailus, Nobuhiro Iwamatsu, Guennadi Liakhovetski,
Vladimir Barinov
On 05/07/2015 08:26 AM, Hans Verkuil wrote:
> Even though the rcar-vin driver tells userspace that it will give a monotonic
> timestamp, it is actually using gettimeofday. Replace this with a proper
> monotonic timestamp.
It was clearly too early in the day for me, but here is my Signed-off-by:
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
> index 35deed8..b64dfea 100644
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
> @@ -894,7 +894,7 @@ static irqreturn_t rcar_vin_irq(int irq, void *data)
>
> priv->queue_buf[slot]->v4l2_buf.field = priv->field;
> priv->queue_buf[slot]->v4l2_buf.sequence = priv->sequence++;
> - do_gettimeofday(&priv->queue_buf[slot]->v4l2_buf.timestamp);
> + v4l2_get_timestamp(&priv->queue_buf[slot]->v4l2_buf.timestamp);
> vb2_buffer_done(priv->queue_buf[slot], VB2_BUF_STATE_DONE);
> priv->queue_buf[slot] = NULL;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rcar-vin: use monotonic timestamps
2015-05-07 6:32 ` Hans Verkuil
@ 2015-05-11 12:45 ` Laurent Pinchart
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2015-05-11 12:45 UTC (permalink / raw)
To: Hans Verkuil
Cc: Linux Media Mailing List, Sakari Ailus, Nobuhiro Iwamatsu,
Guennadi Liakhovetski, Vladimir Barinov
Hi Hans,
On Thursday 07 May 2015 08:32:51 Hans Verkuil wrote:
> On 05/07/2015 08:26 AM, Hans Verkuil wrote:
> > Even though the rcar-vin driver tells userspace that it will give a
> > monotonic timestamp, it is actually using gettimeofday. Replace this with
> > a proper monotonic timestamp.
>
> It was clearly too early in the day for me, but here is my Signed-off-by:
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
And my
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > diff --git a/drivers/media/platform/soc_camera/rcar_vin.c
> > b/drivers/media/platform/soc_camera/rcar_vin.c index 35deed8..b64dfea
> > 100644
> > --- a/drivers/media/platform/soc_camera/rcar_vin.c
> > +++ b/drivers/media/platform/soc_camera/rcar_vin.c
> > @@ -894,7 +894,7 @@ static irqreturn_t rcar_vin_irq(int irq, void *data)
> >
> > priv->queue_buf[slot]->v4l2_buf.field = priv->field;
> > priv->queue_buf[slot]->v4l2_buf.sequence = priv->sequence++;
> >
> > - do_gettimeofday(&priv->queue_buf[slot]->v4l2_buf.timestamp);
> > + v4l2_get_timestamp(&priv->queue_buf[slot]->v4l2_buf.timestamp);
> >
> > vb2_buffer_done(priv->queue_buf[slot], VB2_BUF_STATE_DONE);
> > priv->queue_buf[slot] = NULL;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-11 12:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-07 6:26 [PATCH] rcar-vin: use monotonic timestamps Hans Verkuil
2015-05-07 6:32 ` Hans Verkuil
2015-05-11 12:45 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox