From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:25066 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756010AbbEUN2u (ORCPT ); Thu, 21 May 2015 09:28:50 -0400 Message-id: <555DDD88.8080601@samsung.com> Date: Thu, 21 May 2015 15:28:40 +0200 From: Sylwester Nawrocki MIME-version: 1.0 To: Sakari Ailus , Jacek Anaszewski Cc: linux-leds@vger.kernel.org, linux-media@vger.kernel.org, kyungmin.park@samsung.com, pavel@ucw.cz, cooloney@gmail.com, rpurdie@rpsys.net, devicetree@vger.kernel.org, sre@kernel.org Subject: Re: [PATCH v8 8/8] DT: samsung-fimc: Add examples for samsung,flash-led property References: <1432131015-22397-1-git-send-email-j.anaszewski@samsung.com> <1432131015-22397-9-git-send-email-j.anaszewski@samsung.com> <20150520220018.GE8601@valkosipuli.retiisi.org.uk> <555DA119.9030904@samsung.com> <20150521113213.GI8601@valkosipuli.retiisi.org.uk> In-reply-to: <20150521113213.GI8601@valkosipuli.retiisi.org.uk> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 21/05/15 13:32, Sakari Ailus wrote: >>>> @@ -147,6 +149,8 @@ Example: >>>> > >> clocks = <&camera 0>; >>>> > >> clock-names = "mclk"; >>>> > >> >>>> > >>+ samsung,flash-led = <&rear_cam_flash>; >>>> > >>+ >>>> > >> port { >>>> > >> s5c73m3_1: endpoint { >>>> > >> data-lanes = <1 2 3 4>; >>> > > >>> > >Oops. I missed this property would have ended to the sensor's DT node. I >>> > >don't think we should have properties here that are parsed by another >>> > >driver --- let's discuss this tomorrow. >> > >> > exynos4-is driver already parses sensor nodes (at least their 'port' >> > sub-nodes). > > If you read the code and the comment, it looks like something that should be > done better but hasn't been done yet. :-) That's something we should avoid. > Also, flash devices are by far more common than external ISPs I presume. Yes, especially let's not require any samsung specific properties in other vendors' sensor bindings. One way of modelling [flash led]/[image sensor] association I imagine would be to put, e.g. 'flash-leds' property in the SoC camera host interface/ISP DT node. This property would then contain pairs of phandles, first to the led node and the second to the sensor node, e.g. i2c_controller { ... flash_xx@NN { ... led_a { ... } }; image_sensor_x@NN { ... }; }; flash-leds = <&flash_xx &image_sensor_x>, <...>; For the purpose of this patch set presumably just samsung specific property name could be used (i.e. samsung,flash-leds). -- Thanks, Sylwester