From: Hans Verkuil <hverkuil@xs4all.nl>
To: Florian Echtler <floe@butterbrot.org>,
hans.verkuil@cisco.com, mchehab@osg.samsung.com,
linux-media@vger.kernel.org
Cc: modin@yuri.at
Subject: Re: [PATCH 0/4] [sur40] minor fixes & performance improvements
Date: Mon, 25 May 2015 13:22:46 +0200 [thread overview]
Message-ID: <55630606.8020104@xs4all.nl> (raw)
In-Reply-To: <1432211382-5155-1-git-send-email-floe@butterbrot.org>
Hi Florian,
On 05/21/2015 02:29 PM, Florian Echtler wrote:
> This patch series adds several small fixes, features & performance
> improvements. Many thanks to Martin Kaltenbrunner for testing the
> original driver & submitting the patches.
>
> Martin Kaltenbrunner (4):
> reduce poll interval to allow full 60 FPS framerate
> add frame size/frame rate query functions
> add extra debug output, remove noisy warning
> return BUF_STATE_ERROR if streaming stopped during acquisition
>
> drivers/input/touchscreen/sur40.c | 46 +++++++++++++++++++++++++++++++++++++--
> 1 file changed, 44 insertions(+), 2 deletions(-)
>
The patches look good, but can you repost with better commit logs (i.e. not
just a subject line). Maintainers have become picky about that and without logs
Mauro most likely will not accept it. Actually, I'm not even going to try :-)
Regards,
Hans
next prev parent reply other threads:[~2015-05-25 11:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 12:29 [PATCH 0/4] [sur40] minor fixes & performance improvements Florian Echtler
2015-05-21 12:29 ` [PATCH 1/4] reduce poll interval to allow full 60 FPS framerate Florian Echtler
2015-05-21 12:29 ` [PATCH 2/4] add frame size/frame rate query functions Florian Echtler
2015-05-21 12:29 ` [PATCH 3/4] add extra debug output, remove noisy warning Florian Echtler
2015-05-21 12:29 ` [PATCH 4/4] return BUF_STATE_ERROR if streaming stopped during acquisition Florian Echtler
2015-05-25 11:22 ` Hans Verkuil [this message]
2015-05-25 11:38 ` [PATCH 0/4] [sur40] minor fixes & performance improvements Florian Echtler
2015-05-25 11:39 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55630606.8020104@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=floe@butterbrot.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=modin@yuri.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox