From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wi0-f182.google.com ([209.85.212.182]:38310 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752697AbbEZNFD (ORCPT ); Tue, 26 May 2015 09:05:03 -0400 Received: by wichy4 with SMTP id hy4so80923069wic.1 for ; Tue, 26 May 2015 06:03:41 -0700 (PDT) Message-ID: <55643B07.9010807@gmail.com> Date: Tue, 26 May 2015 10:21:11 +0100 From: Jemma Denson MIME-Version: 1.0 To: Patrick Boettcher CC: linux-media@vger.kernel.org, "mchehab@osg.samsung.com >> Mauro Carvalho Chehab" Subject: Re: [PATCH 3/4] cx24120: Take control of b2c2 receive stream References: <1432326508-6825-1-git-send-email-jdenson@gmail.com> <1432326508-6825-4-git-send-email-jdenson@gmail.com> <20150526110545.32c71335@dibcom294.coe.adi.dibcom.com> In-Reply-To: <20150526110545.32c71335@dibcom294.coe.adi.dibcom.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Patrick, On 26/05/15 10:05, Patrick Boettcher wrote: >> Now that b2c2 has an option to allow us to do so, turn off the >> flexcop receive stream when we turn off mpeg output whilst tuning. > Does this not fix (and your '[PATCH 2/4]') the problem of receiving > PAT from the previously tuned transport-stream? > > Then patch 1 and 4 should not be necessary, should they?! Only patch 1 fixes that problem, so out of the 4 here that one is the most necessary. Controlling the flexcop receive stream and/or stopping the cx24120 from sending doesn't actually appear to do much of anything - it doesn't seem any better or worse doing one or the other, both or even neither! (Apart from Patch 4 breaking things, as mentioned). I'm including it though because I presume the reference driver advised it was done, and it does tidy up the cx24120 codebase considerably by being able to disable the whole turn off sending the stream whilst tuning feature - I'm envisioning that in the future someone might want to take on the task of merging cx24117 & cx24120 as they're quite similar, and allowing what seems to just be a flexcop oddity to be turned off would make this possible. Jemma.