From: Jemma Denson <jdenson@gmail.com>
To: Antti Palosaari <crope@iki.fi>, linux-media@vger.kernel.org
Cc: mchehab@osg.samsung.com, patrick.boettcher@posteo.de
Subject: Re: [PATCH v2 1/4] b2c2: Add option to skip the first 6 pid filters
Date: Mon, 01 Jun 2015 09:08:03 +0100 [thread overview]
Message-ID: <556C12E3.3020404@gmail.com> (raw)
In-Reply-To: <556BF852.80202@iki.fi>
Hi Antti,
On 01/06/15 07:14, Antti Palosaari wrote:
> On 05/30/2015 09:10 PM, Jemma Denson wrote:
>> The flexcop bridge chip has two banks of hardware pid filters -
>> an initial 6, and on some chip revisions an additional bank of 32.
>>
>> A bug is present on the initial 6 - when changing transponders
>> one of two PAT packets from the old transponder would be included
>> in the initial packets from the new transponder. This usually
>> transpired with userspace programs complaining about services
>> missing, because they are seeing a PAT that they would not be
>> expecting. Running in full TS mode does not exhibit this problem,
>> neither does using just the additional 32.
>>
>> This patch adds in an option to not use the inital 6 and solely use
>> just the additional 32, and enables this option for the SkystarS2
>> card. Other cards can be added as required if they also have
>> this bug.
>
> Why not to use strategy where 32 pid filter is used as a priority and
> that buggy 6 pid filter is used only when 32 pid filter is not
> available (or it is already 100% in use)?
>
Yes, that might work, I hadn't though of just swapping them around -
thanks. It would however assume that the 0x0000 PAT feed is requested
early on enough that it always sits within the bank of 32 and nothing
else is too bothered by the odd out of order packet.
The only concern I have got is if there is any other oddness in the
first 6 - this card is the only flexcop based card with dvb-s2 and there
is a lack of stream with high bitrate transponders (>approx. 45Mbps),
which we think might due to the hardware pid filter. The card apparently
works fine under the windows driver so it's a case of trying to work out
what that might be doing differently. It's quite speculative at the
moment but I'm hoping this patch might help with that and I'm waiting
for some feedback on that - I'm stuck with 28.2E which doesn't hold
anything interesting.
At the moment it doesn't really matter too much having only 32 filters
rather than the full 38 - it does switch to full-TS once it runs out of
hardware filters, and the only issue with full-TS is that the flexcop
can't pass a TS with more than 45Mbps (but they aren't working at the
moment anyway)
Jemma.
next prev parent reply other threads:[~2015-06-01 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 18:10 [PATCH v2 0/4] SkystarS2 pid filtering fix and stream control Jemma Denson
2015-05-30 18:10 ` [PATCH v2 1/4] b2c2: Add option to skip the first 6 pid filters Jemma Denson
2015-06-01 6:14 ` Antti Palosaari
2015-06-01 8:08 ` Jemma Denson [this message]
2015-06-01 8:44 ` Patrick Boettcher
2015-05-30 18:10 ` [PATCH v2 2/4] b2c2: Move stream reset code from flexcop-pci to flexcop Jemma Denson
2015-05-30 18:10 ` [PATCH v2 3/4] b2c2: Add external stream control Jemma Denson
2015-05-30 18:10 ` [PATCH v2 4/4] cx24120: Take control of b2c2 streams Jemma Denson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556C12E3.3020404@gmail.com \
--to=jdenson@gmail.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=patrick.boettcher@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox