From: Antti Palosaari <crope@iki.fi>
To: David Howells <dhowells@redhat.com>,
Malcolm Priestley <tvboxspy@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength
Date: Wed, 03 Jun 2015 19:43:32 +0300 [thread overview]
Message-ID: <556F2EB4.6030108@iki.fi> (raw)
In-Reply-To: <31746.1433349441@warthog.procyon.org.uk>
On 06/03/2015 07:37 PM, David Howells wrote:
> Malcolm Priestley <tvboxspy@gmail.com> wrote:
>
>>>> Yes, also, the workqueue appears not to be initialized when using the dvb
>>>> attached method.
>>>
>>> I'm not sure what you're referring to. It's initialised in ts2020_probe()
>>> just after the ts2020_priv struct is allocated - the only place it is
>>> allocated.
>>>
>> ts2020_probe() isn't touched by devices not converted to I2C binding.
>
> Hmmm... Doesn't that expose a larger problem? The only place the ts2020_priv
> struct is allocated is in ts2020_probe() within ts2020.c and the struct
> definition is private to that file and so it can't be allocated from outside.
> So if you don't pass through ts2020_probe(), fe->tuner_priv will remain NULL
> and the driver will crash.
Malcolm misses some pending patches where attach() is wrapped to I2C
model probe().
http://git.linuxtv.org/cgit.cgi/anttip/media_tree.git/log/?h=ts2020
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2015-06-03 16:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 15:04 [PATCH 1/2] TS2020: Calculate tuner gain correctly David Howells
2015-05-26 15:04 ` [PATCH 2/2] ts2020: Provide DVBv5 API signal strength David Howells
2015-05-26 18:58 ` Malcolm Priestley
2015-05-28 10:08 ` David Howells
2015-05-28 20:07 ` Malcolm Priestley
2015-06-03 10:17 ` David Howells
2015-06-03 15:15 ` Malcolm Priestley
2015-06-03 16:37 ` David Howells
2015-06-03 16:43 ` Antti Palosaari [this message]
2015-06-03 17:04 ` Malcolm Priestley
2015-06-03 17:15 ` David Howells
2015-06-03 16:44 ` Malcolm Priestley
2015-06-03 11:13 ` Antti Palosaari
2015-06-03 15:57 ` Malcolm Priestley
2015-06-03 11:35 ` [PATCH] ts2020: Allow stats polling to be suppressed David Howells
2015-06-03 18:33 ` Malcolm Priestley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556F2EB4.6030108@iki.fi \
--to=crope@iki.fi \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).