From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53461 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbbFDKYk (ORCPT ); Thu, 4 Jun 2015 06:24:40 -0400 Message-ID: <55702765.5080401@redhat.com> Date: Thu, 04 Jun 2015 12:24:37 +0200 From: Hans de Goede MIME-Version: 1.0 To: Dan Carpenter CC: Mauro Carvalho Chehab , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] [media] gspca: sn9c2028: remove an unneeded condition References: <20150604085226.GA22838@mwanda> In-Reply-To: <20150604085226.GA22838@mwanda> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi, On 04-06-15 10:52, Dan Carpenter wrote: > We already know status is negative because of the earlier check so there > is no need to check again. > > Signed-off-by: Dan Carpenter Makes sense: Acked-by: Hans de Goede Mauro, can you pick this one up directly please? Regards, Hans > > diff --git a/drivers/media/usb/gspca/sn9c2028.c b/drivers/media/usb/gspca/sn9c2028.c > index c75b738..4f2050a 100644 > --- a/drivers/media/usb/gspca/sn9c2028.c > +++ b/drivers/media/usb/gspca/sn9c2028.c > @@ -140,7 +140,7 @@ static int sn9c2028_long_command(struct gspca_dev *gspca_dev, u8 *command) > status = sn9c2028_read1(gspca_dev); > if (status < 0) { > pr_err("long command status read error %d\n", status); > - return (status < 0) ? status : -EIO; > + return status; > } > > memset(reading, 0, 4); > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >